[GitHub] [beam] ibzib commented on a change in pull request #14058: [BEAM-10961] enable strict dependency checking for sdks/java/io/kinesis

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #14058:
URL: https://github.com/apache/beam/pull/14058#discussion_r581574821



##########
File path: sdks/java/io/kinesis/expansion-service/build.gradle
##########
@@ -21,7 +21,7 @@ apply plugin: 'application'
 mainClassName = "org.apache.beam.sdk.expansion.service.ExpansionService"
 
 applyJavaNature(
-
+    enableStrictDependencies:true,

Review comment:
       ```suggestion
       enableStrictDependencies: true,
   ```

##########
File path: sdks/java/io/kinesis/build.gradle
##########
@@ -17,7 +17,7 @@
  */
 
 plugins { id 'org.apache.beam.module' }
-applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.kinesis')
+applyJavaNature(enableStrictDependencies:true,automaticModuleName: 'org.apache.beam.sdk.io.kinesis')

Review comment:
       ```suggestion
   applyJavaNature(enableStrictDependencies: true, automaticModuleName: 'org.apache.beam.sdk.io.kinesis')
   ```

##########
File path: sdks/java/io/kinesis/expansion-service/build.gradle
##########
@@ -33,6 +33,8 @@ ext.summary = "Expansion service serving KinesisIO"
 
 dependencies {
   compile project(":sdks:java:expansion-service")
+  permitUnusedDeclared project(":sdks:java:expansion-service")

Review comment:
       link the JIRA




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org