You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/08/07 12:27:50 UTC
[GitHub] [iceberg] Fokko commented on a diff in pull request #8243: Parquet: Should not throw exception for filter contains non-reference term
Fokko commented on code in PR #8243:
URL: https://github.com/apache/iceberg/pull/8243#discussion_r1285795715
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -334,5 +335,10 @@ private <T> boolean shouldRead(
return ROWS_MIGHT_MATCH;
}
}
+
+ @Override
+ public <T> Boolean handleNonReference(Bound<T> term) {
+ return ROWS_MIGHT_MATCH;
Review Comment:
When the column is not referenced, then the column is missing, right? How could it then match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org