You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "fatcarter (via GitHub)" <gi...@apache.org> on 2023/06/28 09:04:40 UTC
[GitHub] [dolphinscheduler] fatcarter opened a new issue, #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
fatcarter opened a new issue, #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
in `NettyClientHandler` class , has this code:
```java
/**
* process received logic
*
* @param message command
*/
private void processReceived(final Channel channel, final Message message) {
ResponseFuture future = ResponseFuture.getFuture(message.getOpaque());
if (future != null) {
future.setResponseCommand(message);
future.release();
if (future.getInvokeCallback() != null) {
future.removeFuture();
this.callbackExecutor.submit(future::executeInvokeCallback);
} else {
future.putResponse(message);
}
} else {
processByCommandType(channel, message);
}
}
```
Call method executeInvokeCallback when `getInvokeCallback != null`
in ResponseFuture:
```java
/**
* put response
*
* @param responseMessage responseCommand
*/
public void putResponse(final Message responseMessage) {
this.responseMessage = responseMessage;
this.latch.countDown();
FUTURE_TABLE.remove(opaque);
}
```
`this.latch.countDown()` is called in ResponseFuture, why does future.getInvokeCallback()! = null does not need to be called
### What you expected to happen
nothings
### How to reproduce
nothings
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fatcarter commented on issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
Posted by "fatcarter (via GitHub)" <gi...@apache.org>.
fatcarter commented on issue #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422#issuecomment-1611045186
If I use the `responseFuture.waitResponse()` method, do I have to wait until the timeout to get the result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422#issuecomment-1666298358
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] closed issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
URL: https://github.com/apache/dolphinscheduler/issues/14422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422#issuecomment-1676508021
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #14422: [Bug] [Remot] In NettyClientHandler.class why call method future.executeInvokeCallback directly, but not method future.putResponse
Posted by "caishunfeng (via GitHub)" <gi...@apache.org>.
caishunfeng commented on issue #14422:
URL: https://github.com/apache/dolphinscheduler/issues/14422#issuecomment-1620897136
> If I use the `responseFuture.waitResponse()` method, do I have to wait until the timeout to get the result?
Yes, when you want to send sync, it will wait until timeout or return result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org