You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 01:54:28 UTC
[GitHub] [pulsar] RobertIndie commented on a change in pull request #14259: [Management] Fix print error log when server return redirect (http code 307).
RobertIndie commented on a change in pull request #14259:
URL: https://github.com/apache/pulsar/pull/14259#discussion_r805456393
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -503,10 +503,13 @@ protected void internalCreateMissedPartitions(AsyncResponse asyncResponse) {
return null;
});
}
- }).exceptionally(e -> {
- log.error("[{}] Failed to create partitions for topic {}",
- clientAppId(), topicName);
- resumeAsyncResponseExceptionally(asyncResponse, e);
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we need to log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to create partitions for topic {}",
+ clientAppId(), topicName);
+ }
+ resumeAsyncResponseExceptionally(asyncResponse, ex);
Review comment:
I think we need to use `getCause` here: `ex.getCause`.
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -753,22 +751,23 @@ protected void internalUnloadTopic(AsyncResponse asyncResponse, boolean authorit
} else {
internalUnloadNonPartitionedTopicAsync(asyncResponse, authoritative);
}
- }).exceptionally(t -> {
- log.error("[{}] Failed to get partitioned metadata while unloading topic {}",
- clientAppId(), topicName, t);
- if (t instanceof WebApplicationException) {
- asyncResponse.resume(t);
- } else {
- asyncResponse.resume(new RestException(t));
+ }).exceptionally(ex -> {
+ // If the exception is not redirect exception we need to log it.
+ if (!isRedirectException(ex)) {
+ log.error("[{}] Failed to get partitioned metadata while unloading topic {}",
+ clientAppId(), topicName, ex);
Review comment:
Seems that we need to use `ex.getCause` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org