You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/12 02:51:08 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance

Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378015388
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
 ##########
 @@ -3356,6 +3356,12 @@ public void rebalance(String topoName, RebalanceOptions options)
             if (subject != null) {
                 options.set_principal(subject.getPrincipals().iterator().next().getName());
             }
+            String topoId = toTopoId(topoName);
 
 Review comment:
   I think the change here should not be part of this PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services