You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/12 10:14:51 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4640: Pause a
while when heart beating
kezhenxu94 opened a new pull request #4640: Pause a while when heart beating
URL: https://github.com/apache/skywalking/pull/4640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4640: Fix bug that the
agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#issuecomment-612597289
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=h1) Report
> Merging [#4640](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ce2e9e87398efcee4b646af1143f4dc2ae10dc7&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
- Coverage 29.06% 28.72% -0.35%
==========================================
Files 1192 1192
Lines 26056 26057 +1
Branches 3480 3480
==========================================
- Hits 7574 7484 -90
- Misses 17798 17891 +93
+ Partials 684 682 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `33.33% <0.00%> (-15.73%)` | :arrow_down: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `0.00% <0.00%> (-81.25%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-44.45%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `34.61% <0.00%> (-29.49%)` | :arrow_down: |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `0.00% <0.00%> (-22.23%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `47.36% <0.00%> (-3.51%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `72.60% <0.00%> (-2.74%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=footer). Last update [4ce2e9e...05218a1](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4640: Fix bug
that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#issuecomment-612597289
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=h1) Report
> Merging [#4640](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ce2e9e87398efcee4b646af1143f4dc2ae10dc7&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
- Coverage 29.06% 28.72% -0.35%
==========================================
Files 1192 1192
Lines 26056 26056
Branches 3480 3480
==========================================
- Hits 7574 7484 -90
- Misses 17798 17890 +92
+ Partials 684 682 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `33.96% <33.33%> (-15.10%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `67.85% <100.00%> (ø)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `0.00% <0.00%> (-81.25%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-44.45%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `34.61% <0.00%> (-29.49%)` | :arrow_down: |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `0.00% <0.00%> (-22.23%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `47.36% <0.00%> (-3.51%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=footer). Last update [4ce2e9e...155fd89](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4640:
Fix bug that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#discussion_r407182500
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -85,7 +85,7 @@ property key | Description | Default |
`agent.operation_name_threshold `|The operationName max length, setting this value > 190 is not recommended.|`150`|
`agent.keep_tracing`|Keep tracing even the backend is not available if this value is `true`.|`false`|
`collector.grpc_channel_check_interval`|grpc channel status check interval.|`30`|
-`collector.app_and_service_register_check_interval`|application and service registry check interval.|`3`|
+`collector.heartbeat_period`|application heartbeat period.|`3`|
Review comment:
Wrong default doc 😂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4640: Fix bug
that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#issuecomment-612597289
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=h1) Report
> Merging [#4640](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ce2e9e87398efcee4b646af1143f4dc2ae10dc7&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
- Coverage 29.06% 28.72% -0.35%
==========================================
Files 1192 1192
Lines 26056 26056
Branches 3480 3480
==========================================
- Hits 7574 7484 -90
- Misses 17798 17890 +92
+ Partials 684 682 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `33.96% <33.33%> (-15.10%)` | :arrow_down: |
| [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `67.85% <100.00%> (ø)` | |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `0.00% <0.00%> (-81.25%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-44.45%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `34.61% <0.00%> (-29.49%)` | :arrow_down: |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `0.00% <0.00%> (-22.23%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `47.36% <0.00%> (-3.51%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=footer). Last update [4ce2e9e...fffdde6](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4640: Fix bug that the
agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4640:
Fix bug that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#discussion_r407179623
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -119,7 +119,7 @@
/**
* service and endpoint registry check interval
*/
- public static long APP_AND_SERVICE_REGISTER_CHECK_INTERVAL = 3;
+ public static long HEARTBEAT_PERIOD = 3;
Review comment:
Please fix comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4640: Fix bug that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#discussion_r407182807
##########
File path: docs/en/setup/service-agent/java-agent/README.md
##########
@@ -85,7 +85,7 @@ property key | Description | Default |
`agent.operation_name_threshold `|The operationName max length, setting this value > 190 is not recommended.|`150`|
`agent.keep_tracing`|Keep tracing even the backend is not available if this value is `true`.|`false`|
`collector.grpc_channel_check_interval`|grpc channel status check interval.|`30`|
-`collector.app_and_service_register_check_interval`|application and service registry check interval.|`3`|
+`collector.heartbeat_period`|application heartbeat period.|`3`|
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4640: Fix bug
that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#issuecomment-612597289
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=h1) Report
> Merging [#4640](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4ce2e9e87398efcee4b646af1143f4dc2ae10dc7&el=desc) will **decrease** coverage by `0.34%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4640 +/- ##
==========================================
- Coverage 29.06% 28.72% -0.35%
==========================================
Files 1192 1192
Lines 26056 26056
Branches 3480 3480
==========================================
- Hits 7574 7484 -90
- Misses 17798 17890 +92
+ Partials 684 682 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `33.96% <0.00%> (-15.10%)` | :arrow_down: |
| [.../apm/agent/core/remote/StandardChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1N0YW5kYXJkQ2hhbm5lbEJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../skywalking/apm/agent/core/remote/GRPCChannel.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsLmphdmE=) | `0.00% <0.00%> (-81.25%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lking/apm/agent/core/remote/TLSChannelBuilder.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RMU0NoYW5uZWxCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-44.45%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `34.61% <0.00%> (-29.49%)` | :arrow_down: |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `0.00% <0.00%> (-22.23%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `47.36% <0.00%> (-3.51%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `72.60% <0.00%> (-2.74%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/4640/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=footer). Last update [4ce2e9e...05218a1](https://codecov.io/gh/apache/skywalking/pull/4640?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4640:
Fix bug that the agent heart beats too frequently
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4640: Fix bug that the agent heart beats too frequently
URL: https://github.com/apache/skywalking/pull/4640#discussion_r407179687
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -119,7 +119,7 @@
/**
* service and endpoint registry check interval
*/
- public static long APP_AND_SERVICE_REGISTER_CHECK_INTERVAL = 3;
+ public static long HEARTBEAT_PERIOD = 3;
Review comment:
We could set 40s, as no real register.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services