[PATCH] Issue 3947 - subversion fails with incorrect home directory/HOME variable

[Noorul Islam K M <no...@collab.net>]

In the issue tracker, Sam said:
=======================================================================
issuing svn --version fails if running under user with non-directory as
home directory. The same applies for incorrectly set $HOME variable.
There is imho also no reason to create $HOME/.subversion/* entries if
executing svn with --version parameter only.

how-to reproduce:
$ HOME=/dev/null svn --version
svn: Can't open file '/dev/null/.subversion/servers': Not a directory

$ HOME=/dev/null svn --version --quiet
svn: Can't open file '/dev/null/.subversion/servers': Not a directory

$ touch x
$ HOME=x svn --version --quiet
svn: Can't open file 'x/.subversion/servers': Not a directory
=======================================================================

Looking at the code I could see that we are falling back to default
configuration if the configuration directory is non-readable. I think we
should do the same in the above case also. Attached is the patch for
this.

Log 

[[[

* subversion/svn/main.c
  (main): Fallback to default config if the config directory is
    non-directory. Update comment to reflect the change.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Thanks and Regards
Noorul

RE: [PATCH] Issue 3947 - subversion fails with incorrect home directory/HOME variable

[Bert Huijben <be...@qqmail.nl>]

> -----Original Message-----
> From: Noorul Islam K M [mailto:noorul@collab.net]
> Sent: woensdag 6 juli 2011 12:39
> To: Subversion
> Subject: [PATCH] Issue 3947 - subversion fails with incorrect home
> directory/HOME variable

> [[[
> 
> * subversion/svn/main.c
>   (main): Fallback to default config if the config directory is
>     non-directory. Update comment to reflect the change.
> 
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]

Applied a slightly tweaked version of the patch in r1143377.

Thanks,
	Bert