You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/07/25 08:09:07 UTC
Review Request 23915: Fixing some coverity reported issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/
-----------------------------------------------------------
Review request for cloudstack and Rajani Karuturi.
Repository: cloudstack-git
Description
-------
Fixing some coverity reported issues in CitrixResourceBase.java
Diffs
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
Diff: https://reviews.apache.org/r/23915/diff/
Testing
-------
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48714
-----------------------------------------------------------
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/23915/#comment85476>
please log a message incase rec is null
- Rajani Karuturi
On July 25, 2014, 6:10 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 6:10 a.m.)
>
>
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing some coverity reported issues in CitrixResourceBase.java
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
>
> Diff: https://reviews.apache.org/r/23915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On July 25, 2014, 7:05 a.m., daan Hoogland wrote:
> > Looks ok, did you verify whether the called functions at all return null? If they don't this would seem a false positive. Your change wouldn't hurt anyhow.
I checked the xen code base they are returning null values as well.
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48713
-----------------------------------------------------------
On July 25, 2014, 6:10 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 6:10 a.m.)
>
>
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing some coverity reported issues in CitrixResourceBase.java
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
>
> Diff: https://reviews.apache.org/r/23915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23915: Fixing some coverity reported issues
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48713
-----------------------------------------------------------
Looks ok, did you verify whether the called functions at all return null? If they don't this would seem a false positive. Your change wouldn't hurt anyhow.
- daan Hoogland
On July 25, 2014, 6:10 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 6:10 a.m.)
>
>
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing some coverity reported issues in CitrixResourceBase.java
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
>
> Diff: https://reviews.apache.org/r/23915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Rajani Karuturi <ra...@gmail.com>.
> On July 25, 2014, 10:11 a.m., Rajani Karuturi wrote:
> > Ship It!
commit 0a5940c9a80cfff827c469f92640a70b9037829a
Author: Damodar <da...@citrix.com>
AuthorDate: Fri Jul 25 14:40:21 2014 +0530
Commit: Rajani Karuturi <ra...@gmail.com>
CommitDate: Fri Jul 25 15:34:20 2014 +0530
Coverity: Fixing some of the coverity issues reported in CitrixResourceBase.java.
Signed-off-by: Rajani Karuturi <ra...@gmail.com>
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48719
-----------------------------------------------------------
On July 25, 2014, 9:12 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 9:12 a.m.)
>
>
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing some coverity reported issues in CitrixResourceBase.java
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
>
> Diff: https://reviews.apache.org/r/23915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Rajani Karuturi <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48719
-----------------------------------------------------------
Ship it!
Ship It!
- Rajani Karuturi
On July 25, 2014, 9:12 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
>
> (Updated July 25, 2014, 9:12 a.m.)
>
>
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixing some coverity reported issues in CitrixResourceBase.java
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
>
> Diff: https://reviews.apache.org/r/23915/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/
-----------------------------------------------------------
(Updated July 25, 2014, 9:12 a.m.)
Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
Changes
-------
incorporated Rajain's comments
Repository: cloudstack-git
Description
-------
Fixing some coverity reported issues in CitrixResourceBase.java
Diffs (updated)
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
Diff: https://reviews.apache.org/r/23915/diff/
Testing
-------
Thanks,
Damodar Reddy Talakanti
Re: Review Request 23915: Fixing some coverity reported issues
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/
-----------------------------------------------------------
(Updated July 25, 2014, 6:10 a.m.)
Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
Changes
-------
Adding Santhosh to reviewers list
Repository: cloudstack-git
Description
-------
Fixing some coverity reported issues in CitrixResourceBase.java
Diffs
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java 71aa01e
Diff: https://reviews.apache.org/r/23915/diff/
Testing
-------
Thanks,
Damodar Reddy Talakanti