[GitHub] [cassandra] yifan-c commented on a change in pull request #1168: CASSANDRA-16878 trunk: Race in commit log replay can cause rejected mutations

[GitBox <gi...@apache.org>]

yifan-c commented on a change in pull request #1168:
URL: https://github.com/apache/cassandra/pull/1168#discussion_r797295430



##########
File path: src/java/org/apache/cassandra/schema/SchemaConstants.java
##########
@@ -92,6 +92,14 @@ public static boolean isReplicatedSystemKeyspace(String keyspaceName)
         return REPLICATED_SYSTEM_KEYSPACE_NAMES.contains(keyspaceName.toLowerCase());
     }
 
+    /**
+     * @return whether or not the keyspace is the schema keyspace
+     */
+    public static boolean isSchemaKeyspace(String keyspaceName)
+    {
+        return keyspaceName.toLowerCase().equals(SCHEMA_KEYSPACE_NAME);

Review comment:
       nit: `equalsIgnoreCase()` is less verbose and does not generate a transient lower case string




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org