You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/12/09 22:48:00 UTC
[jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Callers should instead call BlobBuilder.contentMD5, usually with the
results from Guava Hashing.md5(). This narrows the API and removes a
strange IOException from callers.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds deprecate-calculate-md5
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/223
-- Commit Summary --
* Deprecate BlobBuilder.calculateMD5
-- File Changes --
M blobstore/src/main/java/org/jclouds/blobstore/domain/BlobBuilder.java (1)
M blobstore/src/main/java/org/jclouds/blobstore/domain/internal/BlobBuilderImpl.java (1)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/223.patch
https://github.com/jclouds/jclouds/pull/223.diff
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #460](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/460/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30257854
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #438](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/438/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30181610
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #901](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/901/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30181640
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #439](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/439/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30181577
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #902](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/902/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30181641
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30703657
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Gaul <no...@github.com>.
> @@ -121,6 +121,7 @@
> *
> * @see Payloads#calculateMD5
> */
> + @Deprecated
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223/files#r8240776
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Phillips <no...@github.com>.
> @@ -121,6 +121,7 @@
> *
> * @see Payloads#calculateMD5
> */
> + @Deprecated
Add deprecation message to the Javadoc, with pretty much the same content as in the PR description?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223/files#r8213979
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #922](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/922/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30257736
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #905](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/905/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30185080
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Gaul <no...@github.com>.
> @@ -121,6 +121,7 @@
> *
> * @see Payloads#calculateMD5
> */
> + @Deprecated
Done.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223/files#r8215472
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #442](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/442/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223#issuecomment-30185385
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Phillips <no...@github.com>.
> @@ -121,6 +121,7 @@
> *
> * @see Payloads#calculateMD5
> */
> + @Deprecated
Use the [`@deprecated` Javadoc tag](http://docs.oracle.com/javase/1.5.0/docs/guide/javadoc/deprecation/deprecation.html#javadoc_tag)? Renders more nicely in the Javadoc, then.
Happy to amend that myself as part of the merge if it's too much of a hassle.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223/files#r8218192
Re: [jclouds] Deprecate BlobBuilder.calculateMD5 (#223)
Posted by Andrew Phillips <no...@github.com>.
> @@ -146,6 +146,7 @@ public PayloadBlobBuilder payload(Payload payload) {
> return builder.payload(payload);
> }
>
> + @Deprecated
See previous comment?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/223/files#r8213984