[jira] [Comment Edited] (KAFKA-586) system test configs are broken

["John Fung (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484696#comment-13484696 ] 

John Fung edited comment on KAFKA-586 at 10/29/12 6:47 PM:
-----------------------------------------------------------

Hi Neha,

In the structure of the testcase_xxxx_properties.json file as shown below, the attributes in each map are mixed with System Test properties and Broker properties:

    {
      "entity_id": "1",                << System Test property
      "port": "9091",                  << Broker property
      "brokerid": "1",                 << System Test property
      "replica.fetch.min.bytes": "1",
      "log.file.size": "102400",
      "log.dir": "/tmp/kafka_server_1_logs",
      "log_filename": "kafka_server_9091.log",
      "config_filename": "kafka_server_9091.properties"
    },

Since the System Test script cannot tell which property belongs to Broker, it will only match those existing properties from template and update with overridden values to the new broker properties file.

At the mean time, the best solution is to update the template system_test/xxxx_testsuite/config/server.properties with the new properties and the test script will update them properly.
                
      was (Author: jfung):
    Hi Neha,

There is an issue in the structure of the testcase_xxxx_properties.json file. The attributes in each map are mixed with System Test properties and Broker properties:

    {
      "entity_id": "1",                << System Test property
      "port": "9091",                  << Broker property
      "brokerid": "1",                 << System Test property
      "replica.fetch.min.bytes": "1",
      "log.file.size": "102400",
      "log.dir": "/tmp/kafka_server_1_logs",
      "log_filename": "kafka_server_9091.log",
      "config_filename": "kafka_server_9091.properties"
    },

Since the System Test script cannot tell which property belongs to Broker, it will only match those existing properties from template and update with overridden values to the new broker properties file.

At the mean time, the best solution is to update the template system_test/xxxx_testsuite/config/server.properties with the new properties and the test script will update them properly.
                  
> system test configs are broken
> ------------------------------
>
>                 Key: KAFKA-586
>                 URL: https://issues.apache.org/jira/browse/KAFKA-586
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: John Fung
>            Priority: Critical
>              Labels: replication-testing
>         Attachments: kafka-586-v1.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> system test suite has a set of default config values that are picked up from the testsuite/config directory. One can override the value of a config in the testcase_properties.json file. This is great, but the assumption is that the config property that is being overridden should also present in the testsuite/config/*.properties file. 
> Currently, there are a number of properties in KafkaConfig that are not in the testsuite/config/*.properties file. So the tests might intend to override some properties, but that will be ignored. 
> Let's either add all the configs in the testsuite/config/*.properties file or remove this depedency and override the property specified in testcase_properties.json.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira