[GitHub] [poi] pjfanning commented on a change in pull request #206: Improve perfomance of cell evaluation

[GitBox <gi...@apache.org>]

pjfanning commented on a change in pull request #206:
URL: https://github.com/apache/poi/pull/206#discussion_r540110069



##########
File path: src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
##########
@@ -49,6 +48,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
     // use Boolean to have a tri-state for on/off/undefined
     private Boolean _hidden = UNDEFINED;
     private Boolean _collapsed = UNDEFINED;
+    private int number;

Review comment:
       could you call this rowNumber?

##########
File path: src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
##########
@@ -437,6 +437,10 @@ public SXSSFSheet getSheet()
     {
         return _sheet;
     }
+
+	public void setNumber(int rownum) {

Review comment:
       does this need to be public - can't it be package-private? -- can it be called setRowNum? To match the name of getRowNum.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org