You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2007/02/22 08:11:05 UTC

[jira] Created: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

StandardRequestHandler should support the 'sort' parameter
----------------------------------------------------------

                 Key: SOLR-170
                 URL: https://issues.apache.org/jira/browse/SOLR-170
             Project: Solr
          Issue Type: Improvement
            Reporter: Ryan McKinley
            Priority: Minor


dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-170:
-------------------------------

    Attachment: SOLR-170-sort-parameter.patch

This simple patch adds 'sort' param to StandardRequestHandler and updates the tutorial docs to use the sort parameter rather then the ';' syntax

Two things to note:

1. I had to delete some "sort", "true" parameters from the BasicFunctionalityTest.java TestSimpleFacetCounts.  "sort=true" does not evaluate to a valid sort string and these params were being ignored before

2. This patch includes dummy defined constants in SolrParams.  The trunk branch seems to be missing some HIGHLIGHT params.  to get things to compile, i added the following - they should obviously not be commited:

  public static final String HIGHLIGHT_FIELDS = null;
  public static final String HIGHLIGHT = null;
  public static final String MAX_SNIPPETS = null;
  public static final String HIGHLIGHT_FORMATTER_CLASS = null;



> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley reassigned SOLR-170:
----------------------------------

    Assignee: Ryan McKinley

> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-170:
-------------------------------

    Attachment: SOLR-170-sort-parameter.patch

Updated to compile with /trunk

This would be a nice one to squeeze in a solr1.2 release.  It is a minor interface change that will hopefully become the standard.  I am revisiting SOLR-20 and it is easier to have a standard "sort" parameter rather then one that depends if you are using dismax or standard.

> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-170:
-------------------------------

    Attachment: SOLR-170-sort-parameter.patch

Cleaned the patch up a bit.  I'd like to commit it, but someone should take a look first.

This had to modify one line in BasicFunctionalityTest, there was a test that looks like it was trying to test the facet sorting.  it added the parameter "sort"=true to a test -- this was just getting ignored (it should be facet.sort=true) and does not parse as a valid sort field.

> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-170:
-------------------------------

    Attachment: SOLR-170-sort-parameter.patch

Added a new StandardRequestHandlerTest class with a testSorting() function.  

> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-170) StandardRequestHandler should support the 'sort' parameter

Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-170.
--------------------------------

    Resolution: Fixed

commited

> StandardRequestHandler should support the 'sort' parameter
> ----------------------------------------------------------
>
>                 Key: SOLR-170
>                 URL: https://issues.apache.org/jira/browse/SOLR-170
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch, SOLR-170-sort-parameter.patch
>
>
> dismax and standard query handlers should both use the 'sort' parameter.  We should discourage future use of the q=query;sort syntax for StandardRequestHandler 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.