You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "runzhliu (via GitHub)" <gi...@apache.org> on 2023/02/06 03:09:58 UTC
[GitHub] [kyuubi] runzhliu opened a new pull request, #4248: Update kubernetes and minikube version
runzhliu opened a new pull request, #4248:
URL: https://github.com/apache/kyuubi/pull/4248
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
bump the minikube version to 1.29.0 and the kubernetes version to 1.26.1
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420538810
> What's the reason for changeing the used action for minikube ?
Run some tests for the used action and another minikube action, assuming that the used one is not run the full test for the higher version of Kubernetes, it might be the reason for CI failed.
In this case, I prefer to [this way](https://github.com/apache/spark/blob/master/.github/workflows/build_and_test.yml#L945-L966) to setup a minikube cluster for the rest Kubernetes related tests. @bowenliang123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1419187568
> Seems some error encountered in CI. https://github.com/apache/kyuubi/actions/runs/4099996056/jobs/7072995365#step:5:110
>
> Shall we separate them as bumping minikube first and then the kubernetes? @runzhliu
Sure, so I would first bump the version of Minukube in this PR, I'll also take some time to dig into this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420692723
SGTM to install minikube manually like spark does, but please use the specific version instead of latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1100845860
##########
.github/workflows/master.yml:
##########
@@ -394,15 +398,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
- driver: docker
- start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU --force --cpus 2 --memory 4096'
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
Review Comment:
Cache the minikube in a followup PR to avoid file downloading in every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1418489338
# [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4248](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c8b0cc) into [master](https://codecov.io/gh/apache/kyuubi/commit/f6778487ea8071443fe185114dd74f7d6326f1ad?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f677848) will **decrease** coverage by `0.10%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #4248 +/- ##
============================================
- Coverage 53.55% 53.46% -0.10%
Complexity 13 13
============================================
Files 560 560
Lines 30413 30410 -3
Branches 4082 4082
============================================
- Hits 16288 16258 -30
- Misses 12620 12645 +25
- Partials 1505 1507 +2
```
| [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/kyuubi/engine/spark/shim/CatalogShim\_v2\_4.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zaGltL0NhdGFsb2dTaGltX3YyXzQuc2NhbGE=) | `64.06% <0.00%> (-7.58%)` | :arrow_down: |
| [...he/kyuubi/engine/spark/shim/CatalogShim\_v3\_0.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zaGltL0NhdGFsb2dTaGltX3YzXzAuc2NhbGE=) | `80.43% <0.00%> (-6.53%)` | :arrow_down: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `13.84% <0.00%> (-6.16%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `77.77% <0.00%> (-4.05%)` | :arrow_down: |
| [...apache/kyuubi/engine/JpsApplicationOperation.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvSnBzQXBwbGljYXRpb25PcGVyYXRpb24uc2NhbGE=) | `77.41% <0.00%> (-3.23%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `80.00% <0.00%> (-2.67%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `76.59% <0.00%> (-2.13%)` | :arrow_down: |
| [...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xvZy9Mb2dCYXRjaENvbW1hbmQuc2NhbGE=) | `59.09% <0.00%> (-1.52%)` | :arrow_down: |
| [.../engine/spark/session/SparkSQLSessionManager.scala](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU1FMU2Vzc2lvbk1hbmFnZXIuc2NhbGE=) | `78.48% <0.00%> (-1.27%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/kyuubi/pull/4248?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420911479
No problem. I agree with @pan3793 , it's alright to install and use minikube manually without actions as long as in a proper way like Spark does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420650557
Are you using the preferred way as you mentioned in description? I didn't get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu closed pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu closed pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
URL: https://github.com/apache/kyuubi/pull/4248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099992179
##########
.github/workflows/master.yml:
##########
@@ -347,15 +349,16 @@ jobs:
file: build/Dockerfile
load: true
tags: apache/kyuubi:latest
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
+ sudo install minikube-linux-amd64 /usr/local/bin/minikube
+ minikube start --cpus 2 --memory 4096 --kubernetes-version=${KUBERNETES_VERSION} --force
Review Comment:
add a comment to explain why we are doing this resource limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420566769
Try to update the PR title and description with the latest progress and related purposed plan or details. You have tried two different ways for setting up the minikube , the first is `medyagh/setup-minikube` action in the latest commit, the second is the link to Spark with manual installation of minikube.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420891428
>
Sorry to make a mistake, Not at the time when you commented.
Now I just made another commit and trigger the CI process to see if would work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099623688
##########
.github/workflows/master.yml:
##########
@@ -394,15 +394,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
- driver: docker
- start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU --force --cpus 2 --memory 4096'
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/v1.29.0/minikube-linux-amd64
Review Comment:
let's pullout `KUBERNETES_VERSION` and `MINIKUBE_VERSION` to L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1418681882
Seems some error encountered in CI.
https://github.com/apache/kyuubi/actions/runs/4099996056/jobs/7072995365#step:5:110
Shall we bump minikube first and the a followup for bumping kubernetes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420144350
Minikube's Node seems to be not ready, I would run some tests for this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1424147400
Thanks, merged to master/1.7 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099834131
##########
.github/workflows/master.yml:
##########
@@ -394,15 +394,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
- driver: docker
- start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU --force --cpus 2 --memory 4096'
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/v1.29.0/minikube-linux-amd64
Review Comment:
Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] runzhliu commented on pull request #4248: Update version of kubernetes to to 1.26.1 and minikube to 1.29.0
Posted by "runzhliu (via GitHub)" <gi...@apache.org>.
runzhliu commented on PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#issuecomment-1420595379
> Try to update the PR title and description with the latest progress and related purposed plan or details. You have tried two different ways for setting up the minikube , the first is `medyagh/setup-minikube` action in the latest commit, the second is the link to Spark with manual installation of minikube.
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1100845860
##########
.github/workflows/master.yml:
##########
@@ -394,15 +398,12 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
- driver: docker
- start args: '--extra-config=kubeadm.ignore-preflight-errors=NumCPU --force --cpus 2 --memory 4096'
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
Review Comment:
Cache the minikube in a followup PR to avoid file downloading (~75MB) in every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
URL: https://github.com/apache/kyuubi/pull/4248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cfmcgrady commented on a diff in pull request #4248: Modify the GitHub Action of setting up the Minikube cluster
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #4248:
URL: https://github.com/apache/kyuubi/pull/4248#discussion_r1099992975
##########
.github/workflows/master.yml:
##########
@@ -347,15 +349,16 @@ jobs:
file: build/Dockerfile
load: true
tags: apache/kyuubi:latest
- # from https://github.com/marketplace/actions/setup-minikube-kubernetes-cluster
- name: Setup Minikube
- uses: manusa/actions-setup-minikube@v2.7.2
- with:
- minikube version: 'v1.28.0'
- kubernetes version: 'v1.25.4'
- github token: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ # https://minikube.sigs.k8s.io/docs/start/
+ curl -LO https://github.com/kubernetes/minikube/releases/download/${MINIKUBE_VERSION}/minikube-linux-amd64
+ sudo install minikube-linux-amd64 /usr/local/bin/minikube
+ minikube start --cpus 2 --memory 4096 --kubernetes-version=${KUBERNETES_VERSION} --force
+ minikube image load apache/kyuubi:latest
Review Comment:
add a comment to explain why we need to load the local docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org