You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "kafka liu (Created) (JIRA)" <ji...@apache.org> on 2011/11/30 03:47:40 UTC

[jira] [Created] (BUILDR-618) pom properties feature does not support hierarchy

pom properties feature does not support hierarchy
-------------------------------------------------

                 Key: BUILDR-618
                 URL: https://issues.apache.org/jira/browse/BUILDR-618
             Project: Buildr
          Issue Type: Bug
          Components: Packaging
    Affects Versions: 1.4.6
         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
            Reporter: kafka liu


It seems that buildr does not support such properties setting in pom.xml.
Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.

<project>
  <properties>
    <a.version>${b.version}</a.version>
    <b.version>1.1</b.version>
  </properties>
  <artifactId>app</artifactId>
  <groupId>group</groupId>
  <dependencies>
    <dependency>
      <artifactId>library</artifactId>
      <groupId>org.example</groupId>
      <version>${a.version}</version>
      <scope>runtime</scope>
      <exclusions>
        <exclusion>
          <groupId>javax.mail</groupId>
          <artifactId>mail</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
  </dependencies>
</project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "Alex Boisvert (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160562#comment-13160562 ] 

Alex Boisvert commented on BUILDR-618:
--------------------------------------

Kafka, thanks for reporting this and providing a spec!    

Can you please confirm that you are willing to license the code under Apache Software License v2?  This is necessary for us to include it in the project.

thanks!
                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "kafka liu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159913#comment-13159913 ] 

kafka liu commented on BUILDR-618:
----------------------------------

Found the cause, there is an error in pom.rb
line 133 should be: props = props.inject({}) { |mapped, pair| mapped[pair.first] = value_of(pair.last, props) ; mapped }
                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "Peter Donald (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Donald closed BUILDR-618.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4.7
         Assignee: Peter Donald  (was: Alex Boisvert)

Fix applied in r1341804.

Thanks!
                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>            Assignee: Peter Donald
>             Fix For: 1.4.7
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "kafka liu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160571#comment-13160571 ] 

kafka liu commented on BUILDR-618:
----------------------------------

It is my pleasure~ :D
                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>            Assignee: Alex Boisvert
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "kafka liu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160558#comment-13160558 ] 

kafka liu commented on BUILDR-618:
----------------------------------

Pls refer to such rspec test: 

describe Buildr::POM do
  before do
    repositories.remote = 'http://example.com'
    @app = 'group:app:jar:1.0'
    write artifact(@app).pom.to_s, <<-XML
<project>
  <properties>
    <a.version>${b.version}</a.version>
    <b.version>1.1</b.version>
  </properties>
  <artifactId>app</artifactId>
  <groupId>group</groupId>
  <dependencies>
    <dependency>
      <artifactId>library</artifactId>
      <groupId>org.example</groupId>
      <version>${a.version}</version>
      <scope>runtime</scope>
      <exclusions>
        <exclusion>
          <groupId>javax.mail</groupId>
          <artifactId>mail</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
  </dependencies>
</project>
XML
    @library = 'org.example:library:jar:1.1'
    write artifact(@library).pom.to_s, <<-XML
<project>
  <artifactId>app</artifactId>
  <groupId>group</groupId>
  <dependencies>
    <dependency>
      <artifactId>mail</artifactId>
      <groupId>javax.mail</groupId>
      <version>1.0</version>
    </dependency>
    <dependency>
      <artifactId>foo</artifactId>
      <groupId>org.example</groupId>
      <version>2.0</version>
    </dependency>
  </dependencies>
</project>
XML
  end

  it 'should respect exclusions when computing transitive dependencies' do
    pom = POM.load(artifact(@app).pom)
    specs = {"a.version"=>"1.1", "b.version"=>"1.1", "project.groupId"=>"group", "pom.groupId"=>"group", "groupId"=>"group", "project.artifactId"=>"app", "pom.artifactId"=>"app", "artifactId"=>"app"}
    pom.properties.should eql(specs)
  end
end
                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "Alex Boisvert (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert reassigned BUILDR-618:
------------------------------------

    Assignee: Alex Boisvert
    
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>            Assignee: Alex Boisvert
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BUILDR-618) pom properties feature does not support hierarchy

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281515#comment-13281515 ] 

Hudson commented on BUILDR-618:
-------------------------------

Integrated in Buildr-ci-build #320 (See [https://builds.apache.org/job/Buildr-ci-build/320/])
    BUILDR-618 - pom properties feature does not support hierarchy (Revision 1341804)

     Result = FAILURE
donaldp : 
Files : 
* /buildr/trunk/CHANGELOG
* /buildr/trunk/lib/buildr/java/pom.rb
* /buildr/trunk/spec/java/pom_spec.rb

                
> pom properties feature does not support hierarchy
> -------------------------------------------------
>
>                 Key: BUILDR-618
>                 URL: https://issues.apache.org/jira/browse/BUILDR-618
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.4.6
>         Environment: jruby 1.6.5 (ruby-1.8.7-p330) (2011-10-25 9dcd388) (Java HotSpot(TM) 64-Bit Server VM 1.6.0_26) [Windows 7-amd64-java]
>            Reporter: kafka liu
>            Assignee: Peter Donald
>             Fix For: 1.4.7
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It seems that buildr does not support such properties setting in pom.xml.
> Since many artifacts, such as cxf-parent, are using such setting, it will block the build process.
> <project>
>   <properties>
>     <a.version>${b.version}</a.version>
>     <b.version>1.1</b.version>
>   </properties>
>   <artifactId>app</artifactId>
>   <groupId>group</groupId>
>   <dependencies>
>     <dependency>
>       <artifactId>library</artifactId>
>       <groupId>org.example</groupId>
>       <version>${a.version}</version>
>       <scope>runtime</scope>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.mail</groupId>
>           <artifactId>mail</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> </project>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira