[jira] Commented: (JENA-28) Drop Temporary Tables in Postgres (PATCH)

["Damian Steer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JENA-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981027#action_12981027 ] 

Damian Steer commented on JENA-28:
----------------------------------

Stupid question, but won't this drop the entire table? Do subsequent add operations work for you?

> Drop Temporary Tables in Postgres (PATCH)
> -----------------------------------------
>
>                 Key: JENA-28
>                 URL: https://issues.apache.org/jira/browse/JENA-28
>             Project: Jena
>          Issue Type: Improvement
>          Components: SDB
>         Environment: Effects SDB PostgreSQL
>            Reporter: Gavin Carothers
>            Assignee: Damian Steer
>
> Current behaviour to truncate the temporary tables leaves the table objects, and thanks to MVCC in Postgres the data in those tables around for far longer then expected. This causes HUGE write loads on the database when loading a large number of quads or triples transactionally.
> Fix is VERY simple:
> Index: src/com/hp/hpl/jena/sdb/layout2/hash/TupleLoaderHashPGSQL.java
> ===================================================================
> --- src/com/hp/hpl/jena/sdb/layout2/hash/TupleLoaderHashPGSQL.java      (revision 8420)
> +++ src/com/hp/hpl/jena/sdb/layout2/hash/TupleLoaderHashPGSQL.java      (working copy)
> @@ -26,7 +26,7 @@
>         }
>  
>         public String[] getCreateTempTable() {
> -               return new String[] { "CREATE TEMPORARY TABLE" , "ON COMMIT DELETE ROWS" };
> +               return new String[] { "CREATE TEMPORARY TABLE" , "ON COMMIT DROP" };
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.