You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "Ovilia (via GitHub)" <gi...@apache.org> on 2023/07/07 03:43:46 UTC

[GitHub] [echarts] Ovilia commented on a diff in pull request #18381: feat(ssr): server-side rendering and client hydration #18334

Ovilia commented on code in PR #18381:
URL: https://github.com/apache/echarts/pull/18381#discussion_r1255208191


##########
src/core/echarts.ts:
##########
@@ -428,6 +428,15 @@ class ECharts extends Eventful<ECEventDefinition> {
                 : devUseDirtyRect;
         }
 
+        zrender.registerSSRDataGetter(el => {
+            const ecData = getECData(el);
+            const hashMap = createHashMap();
+            hashMap.set('series_index', ecData.seriesIndex);

Review Comment:
   Do you mean we should define the type in ZRender? But ZRender should not know the structures like seriesIndex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org