You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "c-thiel (via GitHub)" <gi...@apache.org> on 2024/06/07 14:02:51 UTC

[I] bug: SnapshotRetention::Tag max_ref_age_ms should be optional [iceberg-rust]

c-thiel opened a new issue, #392:
URL: https://github.com/apache/iceberg-rust/issues/392

   Currently the field `max_ref_age_ms` of the Tag `SnapshotRetention` is required:
   https://github.com/apache/iceberg-rust/blob/f1ea6e137eaabf22ff7d091bfafa0a05739a6516/crates/iceberg/src/spec/snapshot.rs#L354
   
   I believe it should be optional. The comment correctly states that: 'Defaults to table property history.expire.max-ref-age-ms'.
   It can only default to something if its optional, such as all the durations for the `Branch` Variant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] bug: SnapshotRetention::Tag max_ref_age_ms should be optional [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #392: bug: SnapshotRetention::Tag max_ref_age_ms should be optional
URL: https://github.com/apache/iceberg-rust/issues/392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] bug: SnapshotRetention::Tag max_ref_age_ms should be optional [iceberg-rust]

Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #392:
URL: https://github.com/apache/iceberg-rust/issues/392#issuecomment-2165778976

   Close by #391 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org