You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "SteveStevenpoor (via GitHub)" <gi...@apache.org> on 2026/06/22 16:04:21 UTC
[PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
SteveStevenpoor opened a new pull request, #28506:
URL: https://github.com/apache/flink/pull/28506
## What is the purpose of the change
This pull request enables migration tests to check snapshot compatibility between Flink 2.x and current versions.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4776608326
it seems ci is not happy yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "SteveStevenpoor (via GitHub)" <gi...@apache.org>.
SteveStevenpoor commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4782008320
> it seems ci is not happy yet
It is now. Bot didn't listen to me so I pushed an empty commit to retrigger ci. I hope it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #28506:
URL: https://github.com/apache/flink/pull/28506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4770395783
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "da1a0f3ad375222fa1a69dc0fd361289974153e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da1a0f3ad375222fa1a69dc0fd361289974153e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da1a0f3ad375222fa1a69dc0fd361289974153e3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4786748467
>Bot didn't listen to me so I pushed an empty commit to retrigger ci. I hope it's ok
unless there is a merge commit it's fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "SteveStevenpoor (via GitHub)" <gi...@apache.org>.
SteveStevenpoor commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4770461212
@snuyanzin could you check this please?
There is also 1 disabled test `TraversableSerializerUpgradeTest`, which can't be enabled right now. There is `ClassCastException` in `traversible-seriallizer-mutable-list` test. The previously generated seriallizer-snapshot contains `MutableList`. Here we try to cast it to `ListBuffer`:
```scala
override def testDataCondition: Condition[mutable.ListBuffer[Int]] =
new Condition[mutable.ListBuffer[Int]](
(l: mutable.ListBuffer[Int]) => Objects.equals(l, mutable.ListBuffer(1, 2, 3)),
"")
```
I will file a separate ticket, fix this issue, and enable the remaining test.
I also want to file another ticket to generate snapshots for version 2.3 and update the most recently published version accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4786758813
for the future instead of commit message having `[FLINK-37404, FLINK-36334]` use brackets for every jira issue id `[FLINK-37404][FLINK-36334]` otherwise it might break internal parsers...
for this one I will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37404, FLINK-36334][API / Core] Reenable Migration Tests for Filnk 2.x [flink]
Posted by "SteveStevenpoor (via GitHub)" <gi...@apache.org>.
SteveStevenpoor commented on PR #28506:
URL: https://github.com/apache/flink/pull/28506#issuecomment-4780360176
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org