You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeevm (via GitHub)" <gi...@apache.org> on 2023/06/17 11:41:02 UTC
[GitHub] [arrow-rs] zeevm opened a new pull request, #4428: cleanup some unwrap() into proper Result propagation
zeevm opened a new pull request, #4428:
URL: https://github.com/apache/arrow-rs/pull/4428
Cleans up some of the many unwrap() in the code base (last count was 143) with Result porpagation, makes for nicer error handling than panicking the thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #4428: cleanup some `unwrap`() into proper Result propagation, impl `PartialEq` for `ParquetError`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #4428:
URL: https://github.com/apache/arrow-rs/pull/4428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4428: cleanup some `unwrap`() into proper Result propagation, impl `PartialEq` for `ParquetError`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4428:
URL: https://github.com/apache/arrow-rs/pull/4428#discussion_r1247786061
##########
parquet/src/errors.rs:
##########
@@ -44,6 +44,23 @@ pub enum ParquetError {
External(Box<dyn Error + Send + Sync>),
}
+impl PartialEq for ParquetError {
Review Comment:
This is reverted in https://github.com/apache/arrow-rs/pull/4469 as the semantics of the external variant are not well-defined, and in general we don't provide PartialEq for error variants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org