[jira] [Comment Edited] (OODT-491) Finish line tasks for Wengine integration

["Chris A. Mattmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OODT-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476378#comment-13476378 ] 

Chris A. Mattmann edited comment on OODT-491 at 10/15/12 8:03 PM:
------------------------------------------------------------------

Hey BFost:

Thanks, here is what I was thinking:

bq. how do you plan on handling WorkflowInstances updating the appropriate modelId in the WorkflowProcessor they came from (the metadata needs to be flowed through as well)

For us, model ID is WorkflowId, we should set this probably when the workflow is initially created, and then later in fromWorkflowInstance, maybe?

bq. changing the status of a modelId in a WorkflowProcessor? it also looks like you lost support for state change propagating up the parent WorkflowProcessor. A WorkflowInstance will update a status on a leaf WorkflowProcessor and all parent WorkflowProcessors need to then update their statuses.

There's a method here: [updateWorkflowInstanceStatus|http://oodt.apache.org/components/maven/xref/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.html#401] that we can use for this.

bq. Also it appears you lost support for rolling back status to a queued status for a failed workflow – you also need backward status calculation in the WorkflowProcessor. (i know the original long method for determining next state for a WorkflowProcessor, with a ton of if statements, was messy and hard to comprehend, but that is what it accomplished)

Yeah maybe we can make a function to handle this. Thoughts? Or make it part of OODT-495 maybe.
                
      was (Author: chrismattmann):
    Hey BFost:

Thanks, here is what I was thinking:

bq. how do you plan on handling WorkflowInstances updating the appropriate modelId in the WorkflowProcessor they came from (the metadata needs to be flowed through as well)

For us, model ID is WorkflowId, we should set this probably when the workflow is initially created, and then later in fromWorkflowInstance, maybe?

bq. changing the status of a modelId in a WorkflowProcessor? it also looks like you lost support for state change propagating up the parent WorkflowProcessor. A WorkflowInstance will update a status on a leaf WorkflowProcessor and all parent WorkflowProcessors need to then update their statuses.

There's a method here: [http://oodt.apache.org/components/maven/xref/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.html#401|updateWorkflowInstanceStatus] that we can use for this.

bq. Also it appears you lost support for rolling back status to a queued status for a failed workflow – you also need backward status calculation in the WorkflowProcessor. (i know the original long method for determining next state for a WorkflowProcessor, with a ton of if statements, was messy and hard to comprehend, but that is what it accomplished)

Yeah maybe we can make a function to handle this. Thoughts? Or make it part of OODT-495 maybe.

                  
> Finish line tasks for Wengine integration
> -----------------------------------------
>
>                 Key: OODT-491
>                 URL: https://issues.apache.org/jira/browse/OODT-491
>             Project: OODT
>          Issue Type: Umbrella
>          Components: workflow manager
>            Reporter: Chris A. Mattmann
>            Assignee: Chris A. Mattmann
>             Fix For: 0.5
>
>         Attachments: NewWorkflowModel.patch.txt
>
>
> The final tasks to wrap up wengine integration into trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira