You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/12/12 23:43:11 UTC

Review Request 54683: Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54683/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Kevin Klues.


Repository: mesos


Description
-------

Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.hpp fb720f063396790a336170dcb4b103c844c8d2dc 
  src/slave/containerizer/mesos/io/switchboard.cpp 210556f6ea60364a6332a07f294331b4d3457ff0 
  src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd 

Diff: https://reviews.apache.org/r/54683/diff/


Testing
-------

make check


Thanks,

Jie Yu


Re: Review Request 54683: Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54683/#review158930
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Dec. 12, 2016, 11:43 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54683/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 11:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved IOSwitchboardServerFlags nested inside IOSwitchboardServer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.hpp fb720f063396790a336170dcb4b103c844c8d2dc 
>   src/slave/containerizer/mesos/io/switchboard.cpp 210556f6ea60364a6332a07f294331b4d3457ff0 
>   src/slave/containerizer/mesos/io/switchboard_main.cpp 8c4b30aa1a09d3d59f0dd9e81989cd9f3eef89dd 
> 
> Diff: https://reviews.apache.org/r/54683/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>