You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/02/18 09:41:54 UTC

[GitHub] [ratis] guohao-rosicky opened a new pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

guohao-rosicky opened a new pull request #604:
URL: https://github.com/apache/ratis/pull/604


   
   ## What changes were proposed in this pull request?
   
   Streaming tests may fail with TimeoutIOException: Timeout 3000ms
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1513
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ratis] szetszwo merged pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #604:
URL: https://github.com/apache/ratis/pull/604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ratis] guohao-rosicky commented on a change in pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #604:
URL: https://github.com/apache/ratis/pull/604#discussion_r809840342



##########
File path: ratis-common/src/main/java/org/apache/ratis/io/WriteOption.java
##########
@@ -27,4 +27,8 @@ static boolean containsOption(WriteOption[] options, WriteOption target) {
 
     return false;
   }
+
+  default boolean isIn(WriteOption... options) {

Review comment:
       ok,I'll change it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ratis] guohao-rosicky commented on pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #604:
URL: https://github.com/apache/ratis/pull/604#issuecomment-1044250710


   @szetszwo Has been modified


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ratis] guohao-rosicky commented on pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #604:
URL: https://github.com/apache/ratis/pull/604#issuecomment-1044227151


   @szetszwo Please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [ratis] szetszwo commented on a change in pull request #604: RATIS-1513. Streaming tests may fail with TimeoutIOException: Timeout 3000ms

Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #604:
URL: https://github.com/apache/ratis/pull/604#discussion_r809835332



##########
File path: ratis-common/src/main/java/org/apache/ratis/io/WriteOption.java
##########
@@ -27,4 +27,8 @@ static boolean containsOption(WriteOption[] options, WriteOption target) {
 
     return false;
   }
+
+  default boolean isIn(WriteOption... options) {

Review comment:
       Sorry, let's rename it to `isOneOf`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org