You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/11/08 15:50:15 UTC
[GitHub] brooklyn-library pull request #141: Mysql update password
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-library/pull/141
Mysql update password
If you set the `mysql.datadir` in order to specify an existing database, the MySQL entity still tries to set the root password from blank assuming that it's not set. If the existing database has a password set, even if you define `mysql.password`, it errors. This change tries both blank password and the specified password, fixing this problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-library mysql-setpassword
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #141
----
commit e2e3c2230cc0241e77fa7df3ea9af7bb559ed8d5
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-11-08T15:01:52Z
Mysql update password
----
---
[GitHub] brooklyn-library issue #141: Mysql update password
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-library/pull/141
Thanks @geomacy, I agree about the TODO. The shortcomings of the MySQL entity have already been identified in PRs such as #76 and I think a re-write in YAML is the best course of action. In this case, this addresses a specific blocking bug whilst avoiding changing the functionality and risking it breaking in other places.
---
[GitHub] brooklyn-library issue #141: Mysql update password
Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:
https://github.com/apache/brooklyn-library/pull/141
I've tested this by starting this blueprint:
```
brooklyn.catalog:
version: "1.0.0-SNAPSHOT"
items:
- id: test
version: "1.0.0-SNAPSHOT"
itemType: template
license: Apache-2.0
item:
services:
- type: org.apache.brooklyn.entity.software.base.VanillaSoftwareProcess
brooklyn.config:
checkRunning.command: |
echo true
```
Then adding this child:
```
services:
- type: org.apache.brooklyn.entity.database.mysql.MySqlNode
id: db2
name: MySQL node 2
brooklyn.config:
mysql.password: s0m3rand0mp4ss
mysql.datadir: /tmp
datastore.creation.script.url: https://github.com/apache/brooklyn-library/raw/master/examples/simple-web-cluster/src/main/resources/visitors-creation-script.sql
```
Then stopping that child once installed and adding this child:
```
services:
- type: org.apache.brooklyn.entity.database.mysql.MySqlNode
id: db2
name: MySQL node 2
brooklyn.config:
mysql.password: s0m3rand0mp4ss
mysql.datadir: /tmp
```
Everything starts and runs as expected
---
[GitHub] brooklyn-library pull request #141: Mysql update password
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/141
---