You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by granturing <gi...@git.apache.org> on 2016/02/20 16:42:25 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
GitHub user granturing opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/734
[ZEPPELIN-647] - Native Windows support for startup scripts and configuration
### What is this PR for?
This is to give Windows first-class support for running Zeppelin without the need for Cygwin or other hacks.
### What type of PR is it?
Improvement
### Todos
* [ ] - Fix notebook dir path handling which right now assumes URI compatible string (see https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java#L63)
* [ ] - Add full documentation for building, configuring, and running on Windows (and Azure)
* [ ] - Independent code review of the BAT scripts to ensure they're correct
### Is there a relevant Jira issue?
ZEPPELIN-647
### How should this be tested?
* Pull this PR
* Build
* Override default ZEPPELIN_NOTEBOOK_DIR to be an absolute file URI such as file://c:/notebook
* Start with bin\zeppelin.cmd
* If using any Hadoop system ensure you have winutils.exe in your HADOOP_HOME\bin, see (https://github.com/steveloughran/winutils)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/granturing/incubator-zeppelin windows-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 9e404823cf4c56a948cd49fb896c1de6775a70c1
Author: Silvio Fiorito <silvio fiorito>
Date: 2016-02-15T13:54:07Z
Initial support for Windows platform, startup scripts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-199595583
Most of the profiles are green, including those with tests, so LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189873259
Let me checkout the project on Windows and try (I need to find a Windows :D)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-200441262
LGTM. Merge if there're no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by ankurmitujjain <gi...@git.apache.org>.
Github user ankurmitujjain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-187021997
It works on Windows 7 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189872676
@felixcheung
Yes, **Cassandra** is supported on Windows.
The error is about parsing multi line comments. The first test failure looks interesting. Basically it says that the following test fails:
```scala
"Parser" should "parse multi-line comment" in {
val query:String =
"""/*This is a comment
|line1
|line2
|line3
|*/
""".stripMargin
val parsed = parser.parseAll(parser.multiLineComment, query)
parsed should matchPattern {
case parser.Success(Comment("This is a comment\nline1\nline2\nline3\n"), _) =>
}
}
```
because it does not match the regexp pattern: `(?s)/\*(.*)\*/` e.g:
* (?s) = **[DOT ALL mode](http://docs.oracle.com/javase/6/docs/api/java/util/regex/Pattern.html#DOTALL)**
* \\* = start with `\*`
* (.*) = any character
* \*/ = end with `*/`
I'm wondering if it is not related to the difference between Linux/Unix and Windows for the **[line terminator](http://stackoverflow.com/questions/426397/do-line-endings-differ-between-windows-and-linux)**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by "Amos B. Elberg" <am...@gmail.com>.
This PR needs to be a broader discussion.
If Zeppelin is going to support windows, that means making a commitment to support windows. That's means supporting a wider variety of configurations, and varying levels of user ability, orders of magnitude beyond what we do now. How are we going to CI test for what does and doesn't work on different Windows flavors? What about new features and changes that have dependencies that aren't available for Windows?
I suggest that if we move in this direction, we do so on a provisional basis -- for some period of time, say two releases, include the Windows code but say that Windows is in testing and not yet officially supported. That way, we can see what happens in-the-wild, and determine if we have the infrastructure to support it.
> On Mar 17, 2016, at 3:08 PM, granturing <gi...@git.apache.org> wrote:
>
> Github user granturing commented on the pull request:
>
> https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-198037337
>
> I have no more changes. @dnldxn were you able to validate the latest commit on your setup?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-198037337
I have no more changes. @dnldxn were you able to validate the latest commit on your setup?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by dnldxn <gi...@git.apache.org>.
Github user dnldxn commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-196556262
The script seems to have a problem with CLASSPATH's that contain spaces (e.g. C:\Program Files\xyz\bin\). I'm not knowledgeable enough with with Windows Batch scripting to determine if this a problem with the startup script or my particular environment.
The script fails in the following section of "zeppelin.cmd":
```
if "%CLASSPATH%"=="" (
set CLASSPATH=%ZEPPELIN_CLASSPATH%
) else (
set CLASSPATH=%CLASSPATH%;%ZEPPELIN_CLASSPATH%
)
```
The error thrown:
`Error: Could not find or load main class Files\xyx\bin\`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-187097842
I tried it on Windows 7, works well.
Except for these two test failure in cassandra, when I do
`SPARK_VER="1.6.0" HADOOP_VER="2.3" PROFILE="-Pspark-1.6 -Phadoop-2.3 -Ppyspark -Pscalding" BUILD_FLAG="package -Pbuild-distr" TEST_FLAG="verify -Pusing-packaged-distr" TEST_PROJECTS=""`
`mvn $BUILD_FLAG $PROFILE -B`
- should parse multi-line comment *** FAILED ***
[6.7] parsed: Comment(This is a comment
line1
line2
line3
) did not match the given pattern (ParagraphParserTest.scala:113)
- should parse a block queries with comments *** FAILED ***
[24.7] parsed: List(Comment(
This example show how to force a
timestamp on the query
), Comment(Timestamp in the past), Timestamp(10), SimpleStm(CREATE TABLE IF NOT EXISTS spark_demo.ts(key int PRIMARY KEY, value text);), SimpleStm(TRUNCATE spark_demo.ts;), Comment(Force timestamp directly in the first INSERT), SimpleStm(INSERT INTO spark_demo.ts(key,value) VALUES(1,'val1') USING TIMESTAMP 100;), Comment(Selec t some data to loose some time), SimpleStm(SELECT * FROM spark_demo.albums LIMIT 100;), Comment(Use @timestamp value set at the beginning(10)), SimpleStm(INSERT INTO spark_demo.ts(key,value) VALUES(1,'val2');), Comment(Check the result), SimpleStm(SELECT * FROM spark_demo.ts WHERE key=1;)) did not match the given pattern (ParagraphParse rTest.scala:427)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-199591162
One version failed because it couldn't download Spark, the other because of connection refused errors running API tests. My last commit was only against the Windows batch files which aren't being tested in the CI build though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-194682205
I've been running this extensively the past few weeks and have nothing left to add at this point, unless there's additional feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-192086401
Hmm, interesting. Let's keep this here for now then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-198036050
Is it okay to be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-192776037
Couple questions:
* The Shell interpreter uses bash, which obviously won't work on Windows. I've confirmed the interpreter will work with a couple changes to support the Windows CMD shell. I can either set a value to decide which interpreter to use at runtime, based on the OS, or we make it configurable. Is it worth making it configurable?
```Java
private static final boolean isWindows = System.getProperty("os.name")
.startsWith("Windows");
private final String shell = isWindows ? "cmd /c" : "bash -c";
```
* Units tests in the zeppelin-interpreter project have a reference to "../bin/interpreter.sh", which of course won't work on Windows. I've verified the unit tests using "../bin/interpreter.cmd". I just didn't like the fact that when I'm in Windows I can't run all the unit tests. I can either have a static variable which defines what script to use in each unit test or I add a helper class to centralize it and all unit tests reference that. What would you prefer?
```Java
private static final String INTERPRETER_SCRIPT =
System.getProperty("os.name").startsWith("Windows") ?
"../bin/interpreter.cmd" :
"../bin/interpreter.sh";
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/734
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-196634863
@dnldxn thanks for testing that. I changed a few things to better handle spaces. Unfortunately, using the bundled Spark with a ZEPPELIN_HOME with spaces will not work, due to Spark issues. External Spark works fine though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-191828541
So, interestingly enough I only see an issue with Spark (using Hadoop 2.6). Running Flink seems fine, but it could be dependent on the Hadoop client versions being used by the two. But yes, the HDFS interpreter will need to have the necessary Windows dependencies. You want me to pull that line out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189935535
The last CI failure is because of spark release download timeout.
I think we are good to go - how about we track the Windows Cassandra test failure in a new JIRA @prabhjyotsingh @doanduyhai ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-199579294
@granturing Selenium tests failed, could you close/re-open this PR to launch CI again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
Github user granturing commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189935705
Hi Felix, agree with the Cassandra test failure. I have a couple more things I want to verify and then we should be good to go. I'm writing up some docs related to Windows deployment that will be part of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186749794
It works well on my windows XP with oracle jdk 1.7.0_79. great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by granturing <gi...@git.apache.org>.
GitHub user granturing reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/734
[ZEPPELIN-647] - Native Windows support for startup scripts and configuration
### What is this PR for?
This is to give Windows first-class support for running Zeppelin without the need for Cygwin or other hacks.
### What type of PR is it?
Improvement
### Todos
* [x] - Fix notebook dir path handling which right now assumes URI compatible string (see https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java#L63)
* [x] - Add documentation for configuring and running on Windows
* [x] - Independent code review of the CMD scripts to ensure they're correct
### Is there a relevant Jira issue?
ZEPPELIN-647
### How should this be tested?
* Pull this PR
* Build
* Override default ZEPPELIN_NOTEBOOK_DIR in zeppelin-env.cmd to be an absolute file URI such as file:///c:/notebook
* Start with bin\zeppelin.cmd
* If using any Hadoop system ensure you have winutils.exe in your HADOOP_HOME\bin, see (https://github.com/steveloughran/winutils)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/granturing/incubator-zeppelin windows-support
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/734.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #734
----
commit 9e404823cf4c56a948cd49fb896c1de6775a70c1
Author: Silvio Fiorito <silvio fiorito>
Date: 2016-02-15T13:54:07Z
Initial support for Windows platform, startup scripts
commit 5b49d3ebf9a8135cf00da3f5d9d1ea385fbc5618
Author: Silvio Fiorito <silvio fiorito>
Date: 2016-02-21T01:28:21Z
Cleaned up indentation
commit d30e4b98196459769c1a5ec4b543c6992b03cbe0
Author: Silvio Fiorito <silvio fiorito>
Date: 2016-02-21T01:31:28Z
And again fix indentations missed last time
commit c700808b783bbfcc2fc24017a9316aa1d6dd7951
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-02T00:43:56Z
Check for Windows path before creating URI to prevent URISyntaxExecption
commit 2b9f01c8ff2ab5c353a5874e941336ea3789a14c
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-03T01:55:17Z
Fix for pyspark PYTHONPATH environment variable not being set properly due to delayed expansion
commit 03baf62b44d1a691342372f45920c59d97662220
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-03T06:07:35Z
Additional fix for embedded pyspark environment variables
commit 9e8b3094b53736d371b6a5582f2f8c5ba73b4057
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-03T06:09:10Z
Initital doc updates for running on Windows
commit 82acdcf4eb0f8256cf3cdac0c2586c3330c548fc
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-03T06:54:42Z
Merge branch 'master' into windows-support
resolved conflict in docs/install/install.md
commit a1e30973c2fe38eecad59d33cdbd544a1979a40f
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-10T05:04:08Z
Support for Windows CMD shell interpreter
commit db28fe92702321489066add2459658810ccd8235
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-10T05:07:16Z
Support for running unit tests on Windows using the appropriate interpreter script
commit 73aaf4f7d288321c9fae99eeec22b7da1335d91c
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-10T05:08:02Z
Default to the appropriate interpreter when running on Windows
commit 8aadd457629da9f6ee6cce2e40e262e5875b6f00
Author: Silvio Fiorito <si...@granturing.com>
Date: 2016-03-15T03:17:32Z
Fixes to handle spaces in paths properly, both for ZEPPELIN_HOME and CLASSPATH
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189785823
@doanduyhai is cassandra supported on windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-191472507
+1 for track the Windows Cassandra test failure in a new JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by dnldxn <gi...@git.apache.org>.
Github user dnldxn commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-198226908
@granturing Yep, it works great on my Windows 10 system.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-186653407
@granturing Appreciate for the patch!
I'll manually test it in this evening with my windows XP and share the result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-647] - Native Windows s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-194787522
@granturing Thanks for great work. LGTM. Can https://github.com/apache/incubator-zeppelin/pull/749 and https://github.com/apache/incubator-zeppelin/pull/769 also be applied?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---