Re: [PR] IGNITE-23333 СDC is no longer experimental [ignite]

["timoninmaxim (via GitHub)" <gi...@apache.org>]

timoninmaxim commented on code in PR #11567:
URL: https://github.com/apache/ignite/pull/11567#discussion_r1933955208


##########
modules/core/src/main/java/org/apache/ignite/cdc/CdcConsumer.java:
##########
@@ -65,7 +64,6 @@
  * @see CdcEvent
  * @see CacheEntryVersion
  */
-@IgniteExperimental

Review Comment:
   Class should not have references to internal packages (CdcMain).



##########
modules/core/src/main/java/org/apache/ignite/cdc/CdcLoader.java:
##########
@@ -28,14 +28,12 @@
 import org.apache.ignite.internal.util.typedef.F;
 import org.apache.ignite.internal.util.typedef.internal.U;
 import org.apache.ignite.lang.IgniteBiTuple;
-import org.apache.ignite.lang.IgniteExperimental;
 
 import static org.apache.ignite.internal.IgniteComponentType.SPRING;
 
 /**
  * Utility class to load {@link CdcMain} from Spring XML configuration.
  */
-@IgniteExperimental
 public class CdcLoader {

Review Comment:
   Whether this class should be in internal package?



##########
modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcManager.java:
##########
@@ -62,7 +61,6 @@
  * @see CdcConsumer#onEvents(Iterator)
  * @see CdcConsumerState#saveCdcMode(CdcMode)
  */
-@IgniteExperimental

Review Comment:
   CdcManager is still experimental API. This class is responsible for Online CDC, that is experimtenal



##########
modules/core/src/test/resources/org.apache.ignite.util/GridCommandHandlerClusterByClassTest_help.output:
##########
@@ -450,14 +450,12 @@ If the file name isn't specified the output file name is: '<typeId>.bin':
   Finalize partitions update counters:
     control.(sh|bat) --consistency finalize
 
-  [EXPERIMENTAL]

Review Comment:
   Move non-experimental commands before experimental



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org