You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Goden Yao (JIRA)" <ji...@apache.org> on 2016/08/01 22:22:20 UTC
[jira] [Updated] (HAWQ-958) LICENSE file missing checklist
[ https://issues.apache.org/jira/browse/HAWQ-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Goden Yao updated HAWQ-958:
---------------------------
Description:
From [~jmclean] IPMC release VOTE feedback
{quote}
- Please use the short form of the license linking to a license files in LICENSE
- BSD licensed code [3] 3. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py [GY] [~rlei] can you check this one as you're the last committer through HAWQ-837
- BSD license code [7] 7. ./depends/thirdparty/thrift/compiler/cpp/src/md5.? [GY] [~xunzhang] , this one was you through HAWQ-735
- license for this file [9] 9. ./src/backend/port/dynloader/ultrix4.h [GY] original import, this one seems to be postgres license plus a couple others.
- license for this file [10] Are we OK this was taken form GNU C? 10. ./src/port/inet_aton.c [GY] original import
- MIT license PSI [11] 11. ./tools/bin/pythonSrc/PSI-0.3b2_gp/ [GY] [~rlei] this is from HAWQ-837 a month ago, MIT license
- BSD licensed code [12] 12. ./src/port/snprintf.c
- BSD licensed code [13] 13 ./src/port/crypt.c Is this regard as cryptography code? [14] 14. http://www.apache.org/dev/crypto.html
- BSD licensed code [15][16] 15. ./src/port/memcmp.c , 16. ./src/backend/utils/mb/wstrcmp.c
- license for this file [17] 17. ./src/port/rand.c
- license of these files [18][19] 18. ./src/backend/utils/adt/inet_net_ntop.c
19. ./src/backend/utils/adt/inet_net_pton.c
- license of this file [20] 20 ./src/port/strlcpy.c
- regex license [21] 21. ./src/backend/regex/COPYRIGHT
- How are these files licensed? [22] + others copyright AEG Automation GmbH 22. ./src/backend/port/qnx4/shm.c
- How is this file licensed? [23] 23. ./src/backend/port/beos/shm.c
- BSD licensed libpq [24]. 24. ./src/backend/libpq/sha2.?
Is this considered crypto code and may need an export license?
- pgdump [25] 25. ./src/bin/pg_dump/
- license for this file [26] 26. ./src/port/gettimeofday.c
- license for this file [27] Look like an ASF header may of been incorrectly added to this. 27. ./depends/thirdparty/thrift/lib/cpp/src/thrift/windows/SocketPair.cpp
- This BSD licensed file [36] 36. ./src/bin/pg_controldata/pg_controldata.c
- license for these files [37][38] and others in [39]
37. ./depends/thirdparty/thrift/aclocal/ax_cxx_compile_stdcxx_11.m4
38. ./depends/thirdparty/thrift/aclocal/ax_boost_base.m4
39. ./depends/thirdparty/thrift/aclocal
- This BSD licensed file [40]
40. ./depends/thirdparty/thrift/build/cmake/FindGLIB.cmake
- This BSD licensed file [41]
41. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py
- BSD licensed pychecker [42]
42. ./tools/bin/pythonSrc/pychecker-0.8.18/
- licenses for all of these files [43]
43. ./src/interfaces/libpq/po/*.po
- BSD license pg800 [44]
44. ./tools/bin/ext/pg8000/*
- how is this file licensed? [45]
45. ./src/backend/utils/mb/Unicode/UCS_to_GB18030.pl
- license for this file [47] 47 ./tools/bin/pythonSrc/lockfile-0.9.1/lockfile/pidlockfile.py
- Python license for this file [48]. Is this an Apache comparable license? 48 ./tools/bin/pythonSrc/pychecker-0.8.18/pychecker2/symbols.py
- How are these files licensed? [49] Note multiple copyright owners and missing headers.
49. ./src/backend/utils/mb/Unicode/*
- BSD licensed fig leaf. [50] Note that files incorrectly has had ASF headers applied.
50. ./tools/bin/ext/figleaf/*
- This BSD licensed file [51]
51. ./depends/thirdparty/thrift/lib/py/compat/win32/stdint.h
- This public domain style sheet [52]
52. ./tools/bin/pythonSrc/PyGreSQL-4.0/docs/default.css
- This file [53]
53. ./src/test/locale/test-ctype.c
- License for unit test2 [54]
54 ./tools/bin/pythonSrc/unittest2-0.5.1/unittest2/
- MIT licensed lock file [55]
55. ./tools/bin/pythonSrc/lockfile-0.9.1/LICENSE
- JSON code here [56]
56. ./src/include/catalog/JSON
- License for this file [57]
57. ./src/pl/plperl/ppport.h
Looks like GPL/LPGL licensed code may be included [4][5][6] in the release.
4. ./depends/thirdparty/thrift/debian/copyright (end of file)
5. ./depends/thirdparty/thrift/doc/licenses/lgpl-2.1.txt
6. ./tools/bin/gppylib/operations/test/test_package.py
This file [8] and others(?) may incorrectly have an ASF headers on it. Also why does this file have an ASF header with copyright line? [46]
8. ./tools/sbin/hawqstandbywatch.py
46. ./contrib/hawq-hadoop/hawq-mapreduce-tool/src/test/resources/log4j.properties
Code includes code licensed under the 4 clause BSD license which is not compatible with the Apache 2.0 license. [28][29][30][31][32][33] It may be that this clause has been rescinded [35] and it is OK to include but that needs to be checked.
28. ./src/backend/port/dynloader/freebsd.c
29. ./src/backend/port/dynloader/netbsd.c
30. ./src/backend/port/dynloader/openbsd.c
31. ./src/bin/gpfdist/src/gpfdist/glob.c
32. ./src/bin/gpfdist/src/gpfdist/include/glob.h
33. ./src/include/port/win32_msvc/glob.h
34. ./src/port/glob.c -- [Goden] was not in original Justin's feedback but given the context, I think it's in the same comment for [28]-[33] and [35]
35. ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
{quote}
was:
From [~jmclean] IPMC release VOTE feedback
{quote}
- Please use the short form of the license linking to a license files in LICENSE
- BSD licensed code [3] 3. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py [~rlei] can you check this one as you're the last committer through HAWQ-837
- BSD license code [7] 7. ./depends/thirdparty/thrift/compiler/cpp/src/md5.? [~xunzhang] , this one was you through HAWQ-735
- license for this file [9] 9. ./src/backend/port/dynloader/ultrix4.h - this one seems to be postgres license plus a couple others.
- license for this file [10] Are we OK this was taken form GNU C? 10. ./src/port/inet_aton.c
- MIT license PSI [11] 11. ./tools/bin/pythonSrc/PSI-0.3b2_gp/
- BSD licensed code [12] 12. ./src/port/snprintf.c
- BSD licensed code [13] 13 ./src/port/crypt.c Is this regard as cryptography code? [14] 14. http://www.apache.org/dev/crypto.html
- BSD licensed code [15][16] 15. ./src/port/memcmp.c , 16. ./src/backend/utils/mb/wstrcmp.c
- license for this file [17] 17. ./src/port/rand.c
- license of these files [18][19] 18. ./src/backend/utils/adt/inet_net_ntop.c
19. ./src/backend/utils/adt/inet_net_pton.c
- license of this file [20] 20 ./src/port/strlcpy.c
- regex license [21] 21. ./src/backend/regex/COPYRIGHT
- How are these files licensed? [22] + others copyright AEG Automation GmbH 22. ./src/backend/port/qnx4/shm.c
- How is this file licensed? [23] 23. ./src/backend/port/beos/shm.c
- BSD licensed libpq [24]. 24. ./src/backend/libpq/sha2.?
Is this considered crypto code and may need an export license?
- pgdump [25] 25. ./src/bin/pg_dump/
- license for this file [26] 26. ./src/port/gettimeofday.c
- license for this file [27] Look like an ASF header may of been incorrectly added to this. 27. ./depends/thirdparty/thrift/lib/cpp/src/thrift/windows/SocketPair.cpp
- This BSD licensed file [36] 36. ./src/bin/pg_controldata/pg_controldata.c
- license for these files [37][38] and others in [39]
37. ./depends/thirdparty/thrift/aclocal/ax_cxx_compile_stdcxx_11.m4
38. ./depends/thirdparty/thrift/aclocal/ax_boost_base.m4
39. ./depends/thirdparty/thrift/aclocal
- This BSD licensed file [40]
40. ./depends/thirdparty/thrift/build/cmake/FindGLIB.cmake
- This BSD licensed file [41]
41. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py
- BSD licensed pychecker [42]
42. ./tools/bin/pythonSrc/pychecker-0.8.18/
- licenses for all of these files [43]
43. ./src/interfaces/libpq/po/*.po
- BSD license pg800 [44]
44. ./tools/bin/ext/pg8000/*
- how is this file licensed? [45]
45. ./src/backend/utils/mb/Unicode/UCS_to_GB18030.pl
- license for this file [47] 47 ./tools/bin/pythonSrc/lockfile-0.9.1/lockfile/pidlockfile.py
- Python license for this file [48]. Is this an Apache comparable license? 48 ./tools/bin/pythonSrc/pychecker-0.8.18/pychecker2/symbols.py
- How are these files licensed? [49] Note multiple copyright owners and missing headers.
49. ./src/backend/utils/mb/Unicode/*
- BSD licensed fig leaf. [50] Note that files incorrectly has had ASF headers applied.
50. ./tools/bin/ext/figleaf/*
- This BSD licensed file [51]
51. ./depends/thirdparty/thrift/lib/py/compat/win32/stdint.h
- This public domain style sheet [52]
52. ./tools/bin/pythonSrc/PyGreSQL-4.0/docs/default.css
- This file [53]
53. ./src/test/locale/test-ctype.c
- License for unit test2 [54]
54 ./tools/bin/pythonSrc/unittest2-0.5.1/unittest2/
- MIT licensed lock file [55]
55. ./tools/bin/pythonSrc/lockfile-0.9.1/LICENSE
- JSON code here [56]
56. ./src/include/catalog/JSON
- License for this file [57]
57. ./src/pl/plperl/ppport.h
Looks like GPL/LPGL licensed code may be included [4][5][6] in the release.
4. ./depends/thirdparty/thrift/debian/copyright (end of file)
5. ./depends/thirdparty/thrift/doc/licenses/lgpl-2.1.txt
6. ./tools/bin/gppylib/operations/test/test_package.py
This file [8] and others(?) may incorrectly have an ASF headers on it. Also why does this file have an ASF header with copyright line? [46]
8. ./tools/sbin/hawqstandbywatch.py
46. ./contrib/hawq-hadoop/hawq-mapreduce-tool/src/test/resources/log4j.properties
Code includes code licensed under the 4 clause BSD license which is not compatible with the Apache 2.0 license. [28][29][30][31][32][33] It may be that this clause has been rescinded [35] and it is OK to include but that needs to be checked.
28. ./src/backend/port/dynloader/freebsd.c
29. ./src/backend/port/dynloader/netbsd.c
30. ./src/backend/port/dynloader/openbsd.c
31. ./src/bin/gpfdist/src/gpfdist/glob.c
32. ./src/bin/gpfdist/src/gpfdist/include/glob.h
33. ./src/include/port/win32_msvc/glob.h
34. ./src/port/glob.c -- [Goden] was not in original Justin's feedback but given the context, I think it's in the same comment for [28]-[33] and [35]
35. ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
{quote}
> LICENSE file missing checklist
> ------------------------------
>
> Key: HAWQ-958
> URL: https://issues.apache.org/jira/browse/HAWQ-958
> Project: Apache HAWQ
> Issue Type: Task
> Components: Documentation
> Affects Versions: 2.0.0.0-incubating
> Reporter: Goden Yao
> Assignee: Ed Espino
> Priority: Blocker
> Fix For: 2.0.0.0-incubating
>
>
> From [~jmclean] IPMC release VOTE feedback
> {quote}
> - Please use the short form of the license linking to a license files in LICENSE
> - BSD licensed code [3] 3. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py [GY] [~rlei] can you check this one as you're the last committer through HAWQ-837
> - BSD license code [7] 7. ./depends/thirdparty/thrift/compiler/cpp/src/md5.? [GY] [~xunzhang] , this one was you through HAWQ-735
> - license for this file [9] 9. ./src/backend/port/dynloader/ultrix4.h [GY] original import, this one seems to be postgres license plus a couple others.
> - license for this file [10] Are we OK this was taken form GNU C? 10. ./src/port/inet_aton.c [GY] original import
> - MIT license PSI [11] 11. ./tools/bin/pythonSrc/PSI-0.3b2_gp/ [GY] [~rlei] this is from HAWQ-837 a month ago, MIT license
> - BSD licensed code [12] 12. ./src/port/snprintf.c
> - BSD licensed code [13] 13 ./src/port/crypt.c Is this regard as cryptography code? [14] 14. http://www.apache.org/dev/crypto.html
> - BSD licensed code [15][16] 15. ./src/port/memcmp.c , 16. ./src/backend/utils/mb/wstrcmp.c
> - license for this file [17] 17. ./src/port/rand.c
> - license of these files [18][19] 18. ./src/backend/utils/adt/inet_net_ntop.c
> 19. ./src/backend/utils/adt/inet_net_pton.c
> - license of this file [20] 20 ./src/port/strlcpy.c
> - regex license [21] 21. ./src/backend/regex/COPYRIGHT
> - How are these files licensed? [22] + others copyright AEG Automation GmbH 22. ./src/backend/port/qnx4/shm.c
> - How is this file licensed? [23] 23. ./src/backend/port/beos/shm.c
> - BSD licensed libpq [24]. 24. ./src/backend/libpq/sha2.?
> Is this considered crypto code and may need an export license?
> - pgdump [25] 25. ./src/bin/pg_dump/
> - license for this file [26] 26. ./src/port/gettimeofday.c
> - license for this file [27] Look like an ASF header may of been incorrectly added to this. 27. ./depends/thirdparty/thrift/lib/cpp/src/thrift/windows/SocketPair.cpp
> - This BSD licensed file [36] 36. ./src/bin/pg_controldata/pg_controldata.c
> - license for these files [37][38] and others in [39]
> 37. ./depends/thirdparty/thrift/aclocal/ax_cxx_compile_stdcxx_11.m4
> 38. ./depends/thirdparty/thrift/aclocal/ax_boost_base.m4
> 39. ./depends/thirdparty/thrift/aclocal
> - This BSD licensed file [40]
> 40. ./depends/thirdparty/thrift/build/cmake/FindGLIB.cmake
> - This BSD licensed file [41]
> 41. ./tools/bin/pythonSrc/unittest2-0.5.1/setup.py
> - BSD licensed pychecker [42]
> 42. ./tools/bin/pythonSrc/pychecker-0.8.18/
> - licenses for all of these files [43]
> 43. ./src/interfaces/libpq/po/*.po
> - BSD license pg800 [44]
> 44. ./tools/bin/ext/pg8000/*
> - how is this file licensed? [45]
> 45. ./src/backend/utils/mb/Unicode/UCS_to_GB18030.pl
> - license for this file [47] 47 ./tools/bin/pythonSrc/lockfile-0.9.1/lockfile/pidlockfile.py
> - Python license for this file [48]. Is this an Apache comparable license? 48 ./tools/bin/pythonSrc/pychecker-0.8.18/pychecker2/symbols.py
> - How are these files licensed? [49] Note multiple copyright owners and missing headers.
> 49. ./src/backend/utils/mb/Unicode/*
> - BSD licensed fig leaf. [50] Note that files incorrectly has had ASF headers applied.
> 50. ./tools/bin/ext/figleaf/*
> - This BSD licensed file [51]
> 51. ./depends/thirdparty/thrift/lib/py/compat/win32/stdint.h
> - This public domain style sheet [52]
> 52. ./tools/bin/pythonSrc/PyGreSQL-4.0/docs/default.css
> - This file [53]
> 53. ./src/test/locale/test-ctype.c
> - License for unit test2 [54]
> 54 ./tools/bin/pythonSrc/unittest2-0.5.1/unittest2/
> - MIT licensed lock file [55]
> 55. ./tools/bin/pythonSrc/lockfile-0.9.1/LICENSE
> - JSON code here [56]
> 56. ./src/include/catalog/JSON
> - License for this file [57]
> 57. ./src/pl/plperl/ppport.h
> Looks like GPL/LPGL licensed code may be included [4][5][6] in the release.
> 4. ./depends/thirdparty/thrift/debian/copyright (end of file)
> 5. ./depends/thirdparty/thrift/doc/licenses/lgpl-2.1.txt
> 6. ./tools/bin/gppylib/operations/test/test_package.py
> This file [8] and others(?) may incorrectly have an ASF headers on it. Also why does this file have an ASF header with copyright line? [46]
> 8. ./tools/sbin/hawqstandbywatch.py
> 46. ./contrib/hawq-hadoop/hawq-mapreduce-tool/src/test/resources/log4j.properties
> Code includes code licensed under the 4 clause BSD license which is not compatible with the Apache 2.0 license. [28][29][30][31][32][33] It may be that this clause has been rescinded [35] and it is OK to include but that needs to be checked.
> 28. ./src/backend/port/dynloader/freebsd.c
> 29. ./src/backend/port/dynloader/netbsd.c
> 30. ./src/backend/port/dynloader/openbsd.c
> 31. ./src/bin/gpfdist/src/gpfdist/glob.c
> 32. ./src/bin/gpfdist/src/gpfdist/include/glob.h
> 33. ./src/include/port/win32_msvc/glob.h
> 34. ./src/port/glob.c -- [Goden] was not in original Justin's feedback but given the context, I think it's in the same comment for [28]-[33] and [35]
> 35. ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)