You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by KraFusion <gi...@git.apache.org> on 2018/08/16 01:25:00 UTC
[GitHub] spark pull request #22116: Update configuration.md
GitHub user KraFusion opened a pull request:
https://github.com/apache/spark/pull/22116
Update configuration.md
changed $SPARK_HOME/conf/spark-default.conf to $SPARK_HOME/conf/spark-defaults.conf
no testing necessary as this was a change to documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KraFusion/spark-1 patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22116
----
commit 2b2a61c849ddad680819126f8a6fdc28cbbad721
Author: Joey Krabacher <jk...@...>
Date: 2018-08-16T01:24:08Z
Update configuration.md
changed $SPARK_HOME/conf/spark-default.conf to $SPARK_HOME/conf/spark-defaults.conf
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22116
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22116: [DOCS]Update configuration.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22116
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94836/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: [DOCS]Update configuration.md
Posted by KraFusion <gi...@git.apache.org>.
Github user KraFusion commented on the issue:
https://github.com/apache/spark/pull/22116
@srowen Thanks!
yes, my bad. next time I will bundle (better yet I will look for the same issue elsewhere in the docs), and I'll use a better title.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22116
@KraFusion, mind double checking if there's same instance and fixing the PR title to reflect the change? Also should be good to read https://spark.apache.org/contributing.html even though it's a minor change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by KraFusion <gi...@git.apache.org>.
Github user KraFusion commented on the issue:
https://github.com/apache/spark/pull/22116
@HyukjinKwon the same instance did exist in the spark website repo, PR has been merged.
Not sure what to change the title to, the PR instructions don't cover simple typo fixes in documentation that don't have an associated JIRA. Should I prefix the current title with [DOCS] ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22116
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22116
**[Test build #94836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94836/testReport)** for PR 22116 at commit [`2b2a61c`](https://github.com/apache/spark/commit/2b2a61c849ddad680819126f8a6fdc28cbbad721).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22116
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22116
**[Test build #94836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94836/testReport)** for PR 22116 at commit [`2b2a61c`](https://github.com/apache/spark/commit/2b2a61c849ddad680819126f8a6fdc28cbbad721).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22116
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: [DOCS]Update configuration.md
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22116
Merged to master. For the future, a better title and bundling these in one PR would be preferable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: Update configuration.md
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22116
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22116: [DOCS]Update configuration.md
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22116
Huh OK I thought I looked and this had been fixed. Good catch. Also there's an instance in `cloud-integration.md`, worth fixing too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org