[GitHub] [jackrabbit-filevault] kwin commented on a change in pull request #136: JCRVLT-517 fix package cache init in OSGi containers

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #136:
URL: https://github.com/apache/jackrabbit-filevault/pull/136#discussion_r622850545



##########
File path: vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/FSPackageRegistry.java
##########
@@ -185,6 +182,7 @@ public void activate(BundleContext context, Config config) {
         log.info("Jackrabbit Filevault FS Package Registry initialized with home location {}", this.homeDir.getPath());
         this.scope = InstallationScope.valueOf(config.scope());
         this.securityConfig = new AbstractPackageRegistry.SecurityConfig(config.authIdsForHookExecution(), config.authIdsForRootInstallation());
+        loadPackageCache();

Review comment:
       Loading the package cache is crucial before running ExecutionPlanBuilder (look at https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/7/files). But I will come up with a fix which keeps prevents reading the state from FileSystem in case the FSPackageRegistry is just referenced but no methods are called (as it is the case sometimes in https://github.com/apache/sling-org-apache-sling-jcr-packageinit/blob/master/src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org