You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/12/20 11:28:01 UTC
[36/50] [abbrv] kylin git commit: KYLIN-2288 recogonize measure empty
string as zero
KYLIN-2288 recogonize measure empty string as zero
Signed-off-by: Li Yang <li...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/1d53ce9a
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/1d53ce9a
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/1d53ce9a
Branch: refs/heads/master-cdh5.7
Commit: 1d53ce9a0183ec369a681dec29b412f77f681f3e
Parents: d1175d2
Author: NiChuanlei <ni...@360.cn>
Authored: Fri Dec 16 16:10:37 2016 +0800
Committer: Li Yang <li...@apache.org>
Committed: Mon Dec 19 11:50:14 2016 +0800
----------------------------------------------------------------------
.../java/org/apache/kylin/measure/basic/BigDecimalIngester.java | 2 +-
.../main/java/org/apache/kylin/measure/basic/DoubleIngester.java | 2 +-
.../src/main/java/org/apache/kylin/measure/basic/LongIngester.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/1d53ce9a/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java b/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
index b51917c..c7541ab 100644
--- a/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
+++ b/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
@@ -33,7 +33,7 @@ public class BigDecimalIngester extends MeasureIngester<BigDecimal> {
if (values.length > 1)
throw new IllegalArgumentException();
- if (values[0] == null)
+ if (values[0] == null || values[0].length() == 0)
return new BigDecimal(0);
else
return new BigDecimal(values[0]);
http://git-wip-us.apache.org/repos/asf/kylin/blob/1d53ce9a/core-metadata/src/main/java/org/apache/kylin/measure/basic/DoubleIngester.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/basic/DoubleIngester.java b/core-metadata/src/main/java/org/apache/kylin/measure/basic/DoubleIngester.java
index 8356faa..a2f3980 100644
--- a/core-metadata/src/main/java/org/apache/kylin/measure/basic/DoubleIngester.java
+++ b/core-metadata/src/main/java/org/apache/kylin/measure/basic/DoubleIngester.java
@@ -37,7 +37,7 @@ public class DoubleIngester extends MeasureIngester<DoubleMutable> {
throw new IllegalArgumentException();
DoubleMutable l = current;
- if (values[0] == null)
+ if (values[0] == null || values[0].length() == 0)
l.set(0L);
else
l.set(Double.parseDouble(values[0]));
http://git-wip-us.apache.org/repos/asf/kylin/blob/1d53ce9a/core-metadata/src/main/java/org/apache/kylin/measure/basic/LongIngester.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/basic/LongIngester.java b/core-metadata/src/main/java/org/apache/kylin/measure/basic/LongIngester.java
index bfe6fe8..45a1634 100644
--- a/core-metadata/src/main/java/org/apache/kylin/measure/basic/LongIngester.java
+++ b/core-metadata/src/main/java/org/apache/kylin/measure/basic/LongIngester.java
@@ -37,7 +37,7 @@ public class LongIngester extends MeasureIngester<LongMutable> {
throw new IllegalArgumentException();
LongMutable l = current;
- if (values[0] == null)
+ if (values[0] == null || values[0].length() == 0)
l.set(0L);
else
l.set(Long.parseLong(values[0]));