You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/09 10:15:53 UTC

[GitHub] [incubator-doris] yangzhg opened a new pull request #3544: [FIX] fix some doris web page dispaly error 

yangzhg opened a new pull request #3544:
URL: https://github.com/apache/incubator-doris/pull/3544


   a part of #3314
   fix some rander error
   ## navbar
   the navbar cannot highligt according to selected tab
   before:
   ![image](https://user-images.githubusercontent.com/9098473/81470929-45731480-9220-11ea-9d57-b14d88e1a740.png)
   after:
   ![image](https://user-images.githubusercontent.com/9098473/81470960-7bb09400-9220-11ea-83b4-ed13be0f642d.png)
   ## fix missing icon of table 
   before:
   ![image](https://user-images.githubusercontent.com/9098473/81470981-ab5f9c00-9220-11ea-8d57-a7469cee0926.png)
   
   after:
   ![image](https://user-images.githubusercontent.com/9098473/81470970-9551db80-9220-11ea-88af-307d4e442952.png)
   
   ## fix some text box and button randering error
   before
   ![image](https://user-images.githubusercontent.com/9098473/81471002-d1853c00-9220-11ea-8f3a-2985ff930b43.png)
   ![image](https://user-images.githubusercontent.com/9098473/81471010-db0ea400-9220-11ea-87f0-f16c6313be2f.png)
   ![image](https://user-images.githubusercontent.com/9098473/81471027-e792fc80-9220-11ea-834c-5451a0cac0cd.png)
   after:
   ![image](https://user-images.githubusercontent.com/9098473/81471059-0a251580-9221-11ea-93c7-1aa326889a9d.png)
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #3544: [FIX] fix some doris web page dispaly error

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3544:
URL: https://github.com/apache/incubator-doris/pull/3544


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #3544: [FIX] fix some doris web page dispaly error

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3544:
URL: https://github.com/apache/incubator-doris/pull/3544#discussion_r422611714



##########
File path: fe/src/main/java/org/apache/doris/http/action/WebBaseAction.java
##########
@@ -54,33 +54,41 @@
 public class WebBaseAction extends BaseAction {
     private static final Logger LOG = LogManager.getLogger(WebBaseAction.class);
 
-    protected static final String LINE_SEP = System.getProperty("line.separator");
-
     protected static final String PALO_SESSION_ID = "PALO_SESSION_ID";
     private static final long PALO_SESSION_EXPIRED_TIME = 3600 * 24; // one day
 
     protected static final String PAGE_HEADER = "<!DOCTYPE html>"
             + "<html>"
             + "<head>"
-            + "  <title>Baidu Palo</title>"
+            + "  <title>Apache Doris</title>"

Review comment:
       ```suggestion
               + "  <title>Apache Doris(Incubating)</title>"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org