You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/06/19 14:09:10 UTC

[Bug 59722] New: Use StandardCharsets when possible

https://bz.apache.org/bugzilla/show_bug.cgi?id=59722

            Bug ID: 59722
           Summary: Use StandardCharsets when possible
           Product: JMeter
           Version: 3.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: felix.schumacher@internetallee.de

Created attachment 33963
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33963&action=edit
Use StandardCharsets when possible

Use StandardCharsets when possible and try to use the CharSet directly instead
of constructing one from a string.

That way we can reduce a few catch statements and be a bit surer, that we have
used the right constant for a CharSet name.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59722] Use StandardCharsets when possible

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59722

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Date: Sun Jun 19 19:46:02 2016
New Revision: 1749200

URL: http://svn.apache.org/viewvc?rev=1749200&view=rev
Log:
Use StandardCharsets to reduce the possibility of misspelling Charset names.

Bugzilla Id: 59722

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/HTMLAssertion.java
   
jmeter/trunk/src/components/org/apache/jmeter/assertions/XPathAssertion.java
    jmeter/trunk/src/components/org/apache/jmeter/extractor/XPathExtractor.java
   
jmeter/trunk/src/components/org/apache/jmeter/visualizers/RenderAsXPath.java
   
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/GraphiteMetricsSender.java
    jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
    jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
    jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java
    jmeter/trunk/src/core/org/apache/jmeter/save/converters/ConversionHelp.java
    jmeter/trunk/src/core/org/apache/jmeter/util/XPathUtil.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/UrlDecode.java
    jmeter/trunk/src/functions/org/apache/jmeter/functions/UrlEncode.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorThread.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/JTidyHTMLParser.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/PostWriter.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/ConversionUtils.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/EncoderCache.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/TCLogParser.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
   
jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
   
jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59722] Use StandardCharsets when possible

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59722

--- Comment #2 from Sebb <se...@apache.org> ---
Better to use the Charset directly where possible:

URL: http://svn.apache.org/viewvc?rev=1749208&view=rev
Log:
 Use StandardCharsets when possible
 Might as well use the Charset directly
Bugzilla Id: 59722

Modified:
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HttpMirrorThread.java

-- 
You are receiving this mail because:
You are the assignee for the bug.