You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/03 04:25:10 UTC
[GitHub] [incubator-doris] yangzhg opened a new issue #3756: BinaryPredict's equals function compares ignore the op
yangzhg opened a new issue #3756:
URL: https://github.com/apache/incubator-doris/issues/3756
**Describe the bug**
BinaryPredict's equals function compares ignore the op, the opcode is not init in this class, it will always be INVALID_OPCODE, so if a BinaryPredict has same child it will be qual, like `a<1` and `a>=1`
```
@Override
public boolean equals(Object obj) {
if (!super.equals(obj)) {
return false;
}
return ((BinaryPredicate) obj).opcode == this.opcode;
}
```
**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Expected behavior**
A clear and concise description of what you expected to happen.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
**Additional context**
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #3756: BinaryPredict's equals function compares ignore the op
Posted by GitBox <gi...@apache.org>.
morningman closed issue #3756:
URL: https://github.com/apache/incubator-doris/issues/3756
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org