[Bug 122024] [sidebar] Dispatch interception is broken

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=122024

Andre <aw...@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awf.aoo@googlemail.com

--- Comment #1 from Andre <aw...@googlemail.com> ---
This is probably another example of the sidebar panels not using the standard
toolbar controllers.  But it is also caused by a gap of functionality between
slots and commands: Most sidebar panels use the usual SFX2 slot mechanism to
make (asynchronous) function calls, like most of the rest of AOO.  For some
reason the dispatch interception of UNO commands has not been ported to slots.

There are three ways to fix this

1 Modify all relevant panels to explicitly support dispatch interception. 
Maybe this could be handled by extending the sidebar ControllerItem.

2 Convert the sidebar controls to use toolbar controllers instead of spelling
everything out explicitly.

3 Integrate dispatch interception into slot handling.


I think that 3 would be the best and most elegant solution but would likely
introduce subtle regressions that would be hard to find.  We should do 2 anyway
when time premits (after the 4.0 release).  Option 1 would basically be a waste
of time but seems to be the only practical way to fix at least the text
property panel for a 4.0 release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.