[jira] [Commented] (ISIS-621) Wicket viewer's parsing of numbers silently ignores invalidly formatted numbers

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838416#comment-13838416 ] 

ASF subversion and git services commented on ISIS-621:
------------------------------------------------------

Commit 48c9e60b0b3a7ae4715325e7f856e77929fe28e5 in branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=48c9e60 ]

ISIS-621: improvements to numeric panel converters


> Wicket viewer's parsing of numbers silently ignores invalidly formatted numbers
> -------------------------------------------------------------------------------
>
>                 Key: ISIS-621
>                 URL: https://issues.apache.org/jira/browse/ISIS-621
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.3.1
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: viewer-wicket-1.4.0
>
>
> Noticed with BigDecimal (but also an issue for other numeric types)...
> "When a field is mandatory you can enter anything. There is no check if an actual  value is  number being  entered.
> As an example: when a user enters 100,50 it is not being parsed as number but no feedback is returned ."
> In fact, looking at the code, the Wicket framework provides a bunch of IConverter implementations, which we should use.  (Strangely, there is none for BigInteger, but can subclass AbstractIntegerConverter).



--
This message was sent by Atlassian JIRA
(v6.1#6144)