[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3498: ARTEMIS-2870: Transfer connection close/failure listeners one by one …

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3498:
URL: https://github.com/apache/activemq-artemis/pull/3498#discussion_r597286698



##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/reattach/ReattachTest.java
##########
@@ -133,18 +134,31 @@ public void testReattachTransferConnectionOnSession() throws Exception {
       locator.setRetryInterval(retryInterval).setRetryIntervalMultiplier(retryMultiplier).setReconnectAttempts(reconnectAttempts).setConfirmationWindowSize(1024 * 1024);
       ClientSessionFactoryInternal sf = (ClientSessionFactoryInternal) createSessionFactory(locator);
       ClientSession session = sf.createSession(false, true, true);
+      ClientSession secondSession = sf.createSession(false, true, true);

Review comment:
       no need to make this change... but I'm creating a second test on top of this one
   
   Your change is going into testReattachTransferConnectionOnSession2().
   
   
   
   I will do this as part of the merge and amending this as you.. you will still be the author of the commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org