You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 07:14:01 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #367: use prettier to format md files
Jimexist opened a new pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #367: use prettier to format md files
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367#issuecomment-844806350
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#367](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4d7a90) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/2f73558b6ed68974f2b63d64bef4628b0776d3d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f73558) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head a4d7a90 differs from pull request most recent head 8e972b0. Consider uploading reports for the commit 8e972b0 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 143 143
Lines 23773 23773
=======================================
Hits 18041 18041
Misses 5732 5732
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f73558...8e972b0](https://codecov.io/gh/apache/arrow-datafusion/pull/367?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #367: use prettier to format md files
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #367: use prettier to format md files
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367#discussion_r637922753
##########
File path: datafusion/docs/cli.md
##########
@@ -45,16 +45,23 @@ docker run -it -v $(your_data_location):/data datafusion-cli
## Usage
```
+DataFusion 4.0.0-SNAPSHOT
+DataFusion is an in-memory query engine that uses Apache Arrow as the memory model. It supports executing SQL queries
+against CSV and Parquet files as well as querying directly against in-memory data.
+
USAGE:
- datafusion-cli [OPTIONS]
+ datafusion-cli [FLAGS] [OPTIONS]
FLAGS:
-h, --help Prints help information
+ -q, --quiet Reduce printing other than the results and work quietly
-V, --version Prints version information
OPTIONS:
- -c, --batch-size <batch-size> The batch size of each query, default value is 1048576
+ -c, --batch-size <batch-size> The batch size of each query, or use DataFusion default
Review comment:
π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #367: use prettier to format md files
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367#issuecomment-847035423
> Look good π @Jimexist should we also add a .prettierrc file if we used custom settings & lint task during build? Maybe a separate PR at a later time is fine as well.
The philosophy of prettier is to apply as little config as possible so if not necessary I can leave out the rc file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #367: use prettier to format md files
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #367:
URL: https://github.com/apache/arrow-datafusion/pull/367#issuecomment-847034269
> I reviewed the rendered changes manually by looking at
>
> https://github.com/Jimexist/arrow-datafusion/tree/update-docs-format
>
>
>
> And they look good -- thanks @Jimexist
Thanks I've been thinking of adding a non failing CI job so that future changes can be detected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org