You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/21 11:15:21 UTC

[GitHub] [arrow-rs] alanhe opened a new issue, #2118: Publicly export MapFieldNames

alanhe opened a new issue, #2118:
URL: https://github.com/apache/arrow-rs/issues/2118

   **Describe your question**
   `arrow::array::MapBuilder` is public (https://github.com/apache/arrow-rs/pull/1355), but `MapFieldNames` is not, making it impossible to call `new()` and `with_capacity()` with a proper value.
   
   https://github.com/apache/arrow-rs/blob/3096591520d303eb34a432c82733e86f34999232/arrow/src/array/builder/map_builder.rs#L61-L68
   
   I guess `MapFieldNames` should be exported too, should it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] alamb commented on issue #2118: Publicly export MapFieldNames

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2118:
URL: https://github.com/apache/arrow-rs/issues/2118#issuecomment-1192803511

   @tustvold  is this a regression in 19.0.0 (aka should I cut a new release candidate)?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #2118: Publicly export MapFieldNames

Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2118:
URL: https://github.com/apache/arrow-rs/issues/2118#issuecomment-1192811507

   I think it was a regression that landed in 17.0.0 and was only just noticed...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #2118: Publicly export MapFieldNames

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #2118: Publicly export MapFieldNames
URL: https://github.com/apache/arrow-rs/issues/2118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #2118: Publicly export MapFieldNames

Posted by GitBox <gi...@apache.org>.
tustvold commented on issue #2118:
URL: https://github.com/apache/arrow-rs/issues/2118#issuecomment-1192772392

   This was an accidental bug introduced by #1879 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org