You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-user@incubator.apache.org by Chris Lowe <ch...@gmail.com> on 2007/01/18 23:16:43 UTC
CSS Conditional Comments Bug?
Hi,
I have some CSS conditional comments in my facelets code:
<!--[if IE 6]>
<p>IE 6.0</p>
<![endif]-->
However, when this is rendered I get a spaces introduced around the
opening/closing comments:
<!-- [if IE 6]>
<p>IE 6.0</p>
<![endif] -->
This prevents the CSS conditional from being parsed in IE.
After some snooping, I found the problem lies in the class
org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292 and
294: <http://org.apache.myfaces.trinidadinternal.io>
@Override
public void writeComment(Object comment) throws IOException
{
if (comment != null)
{
_closeStartIfNecessary();
_out.write("<!-- ");
_out.write(comment.toString());
_out.write(" -->");
}
}
Should this method be adding spaces? Should I raise a case / submit a patch
for this?
Regards,
Chris.
Re: CSS Conditional Comments Bug?
Posted by Chris Lowe <ch...@gmail.com>.
Thanks Adam - much appreciated.
Chris.
On 19/01/07, Adam Winer <aw...@gmail.com> wrote:
>
> A JIRA issue is the traditional thing going forward. Anyway,
> fixed (on trunk).
>
> -- Adam
>
>
> On 1/19/07, Chris Lowe <ch...@gmail.com> wrote:
> > That's a relief. Going forward, are you happy dealing with it or should
> I
> > open a JIRI case? I appreciate you guys are busy, so if there is
> anything I
> > can do to help then just ask.
> >
> > Best Regards,
> >
> > Chris.
> >
> >
> >
> > On 19/01/07, Adam Winer <aw...@gmail.com> wrote:
> > >
> > > No, it should not be adding spaces.
> > >
> > > -- Adam
> > >
> > >
> > > On 1/18/07, Chris Lowe <ch...@gmail.com> wrote:
> > > >
> > > > Hi,
> > > >
> > > > I have some CSS conditional comments in my facelets code:
> > > >
> > > > <!--[if IE 6]>
> > > > <p>IE 6.0</p>
> > > > <![endif]-->
> > > >
> > > > However, when this is rendered I get a spaces introduced around the
> > > > opening/closing comments:
> > > >
> > > > <!-- [if IE 6]>
> > > > <p>IE 6.0</p>
> > > > <![endif] -->
> > > >
> > > > This prevents the CSS conditional from being parsed in IE.
> > > >
> > > > After some snooping, I found the problem lies in the class
> > > > org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292
> and
> > > > 294: <http://org.apache.myfaces.trinidadinternal.io>
> > > >
> > > > @Override
> > > > public void writeComment(Object comment) throws IOException
> > > > {
> > > > if (comment != null)
> > > > {
> > > > _closeStartIfNecessary();
> > > > _out.write("<!-- ");
> > > > _out.write(comment.toString());
> > > > _out.write(" -->");
> > > > }
> > > > }
> > > >
> > > > Should this method be adding spaces? Should I raise a case / submit
> a
> > > > patch
> > > > for this?
> > > >
> > > > Regards,
> > > >
> > > > Chris.
> > > >
> > > >
> > >
> > >
> >
> >
>
Re: CSS Conditional Comments Bug?
Posted by Adam Winer <aw...@gmail.com>.
A JIRA issue is the traditional thing going forward. Anyway,
fixed (on trunk).
-- Adam
On 1/19/07, Chris Lowe <ch...@gmail.com> wrote:
> That's a relief. Going forward, are you happy dealing with it or should I
> open a JIRI case? I appreciate you guys are busy, so if there is anything I
> can do to help then just ask.
>
> Best Regards,
>
> Chris.
>
>
>
> On 19/01/07, Adam Winer <aw...@gmail.com> wrote:
> >
> > No, it should not be adding spaces.
> >
> > -- Adam
> >
> >
> > On 1/18/07, Chris Lowe <ch...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > I have some CSS conditional comments in my facelets code:
> > >
> > > <!--[if IE 6]>
> > > <p>IE 6.0</p>
> > > <![endif]-->
> > >
> > > However, when this is rendered I get a spaces introduced around the
> > > opening/closing comments:
> > >
> > > <!-- [if IE 6]>
> > > <p>IE 6.0</p>
> > > <![endif] -->
> > >
> > > This prevents the CSS conditional from being parsed in IE.
> > >
> > > After some snooping, I found the problem lies in the class
> > > org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292 and
> > > 294: <http://org.apache.myfaces.trinidadinternal.io>
> > >
> > > @Override
> > > public void writeComment(Object comment) throws IOException
> > > {
> > > if (comment != null)
> > > {
> > > _closeStartIfNecessary();
> > > _out.write("<!-- ");
> > > _out.write(comment.toString());
> > > _out.write(" -->");
> > > }
> > > }
> > >
> > > Should this method be adding spaces? Should I raise a case / submit a
> > > patch
> > > for this?
> > >
> > > Regards,
> > >
> > > Chris.
> > >
> > >
> >
> >
>
>
Re: CSS Conditional Comments Bug?
Posted by Chris Lowe <ch...@gmail.com>.
That's a relief. Going forward, are you happy dealing with it or should I
open a JIRI case? I appreciate you guys are busy, so if there is anything I
can do to help then just ask.
Best Regards,
Chris.
On 19/01/07, Adam Winer <aw...@gmail.com> wrote:
>
> No, it should not be adding spaces.
>
> -- Adam
>
>
> On 1/18/07, Chris Lowe <ch...@gmail.com> wrote:
> >
> > Hi,
> >
> > I have some CSS conditional comments in my facelets code:
> >
> > <!--[if IE 6]>
> > <p>IE 6.0</p>
> > <![endif]-->
> >
> > However, when this is rendered I get a spaces introduced around the
> > opening/closing comments:
> >
> > <!-- [if IE 6]>
> > <p>IE 6.0</p>
> > <![endif] -->
> >
> > This prevents the CSS conditional from being parsed in IE.
> >
> > After some snooping, I found the problem lies in the class
> > org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292 and
> > 294: <http://org.apache.myfaces.trinidadinternal.io>
> >
> > @Override
> > public void writeComment(Object comment) throws IOException
> > {
> > if (comment != null)
> > {
> > _closeStartIfNecessary();
> > _out.write("<!-- ");
> > _out.write(comment.toString());
> > _out.write(" -->");
> > }
> > }
> >
> > Should this method be adding spaces? Should I raise a case / submit a
> > patch
> > for this?
> >
> > Regards,
> >
> > Chris.
> >
> >
>
>
Re: CSS Conditional Comments Bug?
Posted by Adam Winer <aw...@gmail.com>.
No, it should not be adding spaces.
-- Adam
On 1/18/07, Chris Lowe <ch...@gmail.com> wrote:
>
> Hi,
>
> I have some CSS conditional comments in my facelets code:
>
> <!--[if IE 6]>
> <p>IE 6.0</p>
> <![endif]-->
>
> However, when this is rendered I get a spaces introduced around the
> opening/closing comments:
>
> <!-- [if IE 6]>
> <p>IE 6.0</p>
> <![endif] -->
>
> This prevents the CSS conditional from being parsed in IE.
>
> After some snooping, I found the problem lies in the class
> org.apache.myfaces.trinidadinternal.io.HtmlResponseWriter, lines 292 and
> 294: <http://org.apache.myfaces.trinidadinternal.io>
>
> @Override
> public void writeComment(Object comment) throws IOException
> {
> if (comment != null)
> {
> _closeStartIfNecessary();
> _out.write("<!-- ");
> _out.write(comment.toString());
> _out.write(" -->");
> }
> }
>
> Should this method be adding spaces? Should I raise a case / submit a
> patch
> for this?
>
> Regards,
>
> Chris.
>
>