You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by gb...@apache.org on 2013/11/17 15:56:28 UTC
svn commit: r1542741 [1/3] - in
/subversion/branches/invoke-diff-cmd-feature: BRANCH-README
subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Author: gbg
Date: Sun Nov 17 14:56:28 2013
New Revision: 1542741
URL: http://svn.apache.org/r1542741
Log:
On the invoke-diff-cmd-feature branch: Update BRANCH-README file.
Trivial white space changes to assorted files.
* BRANCH-README: Update general shape and rework all log messages.
Add new diff file.
Modified:
subversion/branches/invoke-diff-cmd-feature/BRANCH-README
subversion/branches/invoke-diff-cmd-feature/subversion/include/svn_io.h
subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_client/diff.c
subversion/branches/invoke-diff-cmd-feature/subversion/svn/svn.c
subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c
Re: svn commit: r1542741 [1/3] - in /subversion/branches/invoke-diff-cmd-feature:
BRANCH-README subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Posted by Branko Čibej <br...@wandisco.com>.
On 17.11.2013 21:44, Gabriela Gibson wrote:
> Thanks Brane,
>
> no :) plain fact is that I didn't think that changing code I messed up
> within the branch and then fixed as significant.
We have a policy about log messages, regardless of where the commit is
made. That's the long and short of it. If you're a (partial) committer
on this project, you will follow the rules that the community has
constrained itself with, and *you*** have promised to follow by
accepting comitter status.
We can change the policy, if we reach consensus about that. But we
haven't yet. And frankly I'm tired of debating this with you.
> I sort of see the branch as a semi-private space, where I do stuff
> that you can look at, but that doesn't have much meaning (hence me
> terming N changes in M files as 'trivial' -- it's jst a bit of of umm
> ascii) until it's good and ready for me to invite scrutiny. Privacy
> for patzers :)
You're committing to the public repository of an open-source project, so
there's no such thing as privacy in that respect.
> Maybe what is needed is a personal commit space where I can reign
> supreme. (fact is, my computer is ancient (but nice and familiar to
> use) and I don't trust it.)
Then propose a change to our policy, with appropriate changes to the
HACKING docs, for establishing such a space. Just note that even if we
do establish such an area, it's likely to have two limitations:
* you'd only be able to commit code related to the project;
* you'd still have to write a proper log message if you merge from
such a private area to trunk or some other non-private branch.
> My other problem is that Apache code carries a copyright, so I'm
> reluctant to use newfangled things like clouds and their fancy
> (loooong) usage legalese that could get me (and Apache) into trouble.
> (some ppl just like to see the world burn and the lawyers earn).
The above leads me to suspect that you haven't read, or understood, the
Apache License. I wonder how you came to sign the ICLA then ...
> I also hope not to give ppl too much useless work, hence me leaving
> off certain log messages off b/c they really are a waste of human
> time, it's just where I goofed and not worth anyone's time. That's
> the main concept here, I'm trying to save your time, probably in the
> wrong way :)
You're actually creating more work for people. I've spent more time
debating log messages with you in the last week than in several years
before.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com
Re: svn commit: r1542741 [1/3] - in /subversion/branches/invoke-diff-cmd-feature:
BRANCH-README subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Posted by Gabriela Gibson <ga...@gmail.com>.
Thanks Brane,
no :) plain fact is that I didn't think that changing code I messed up
within the branch and then fixed as significant.
I sort of see the branch as a semi-private space, where I do stuff that you
can look at, but that doesn't have much meaning (hence me terming N changes
in M files as 'trivial' -- it's jst a bit of of umm ascii) until it's good
and ready for me to invite scrutiny. Privacy for patzers :)
Maybe what is needed is a personal commit space where I can reign supreme.
(fact is, my computer is ancient (but nice and familiar to use) and I don't
trust it.)
My other problem is that Apache code carries a copyright, so I'm reluctant
to use newfangled things like clouds and their fancy (loooong) usage
legalese that could get me (and Apache) into trouble. (some ppl just like
to see the world burn and the lawyers earn).
I also hope not to give ppl too much useless work, hence me leaving off
certain log messages off b/c they really are a waste of human time, it's
just where I goofed and not worth anyone's time. That's the main concept
here, I'm trying to save your time, probably in the wrong way :)
Gabriela
On Sun, Nov 17, 2013 at 8:19 PM, Branko Čibej <br...@wandisco.com> wrote:
> On 17.11.2013 21:08, Gabriela Gibson wrote:
>
> Thank you Ivan,
>
> I was blithely assuming that because I was removing trivial changes I
> introduced to the branch, that no-one would track them :) Also I was
> trying to avoid writing trivial things for people to read.
>
> The log message is fixed now.
>
> Now I'm curious -- what tools do people use to revise patches that allow
> them to instantly spot (seemingly) minor additions?
>
>
> Do you mean "revise patches" or "review commits"? If it's the latter, the
> fact that the list of affected files in the log message and the
> automatically generated list of changes in the commit mail are different is
> an obvious hint that something was either left out of the log message, or
> inadvertently committed.
>
> -- Brane
>
>
> --
> Branko Čibej | Director of Subversion
> WANdisco // Non-Stop Data
> e. brane@wandisco.com
>
Re: svn commit: r1542741 [1/3] - in /subversion/branches/invoke-diff-cmd-feature:
BRANCH-README subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Posted by Branko Čibej <br...@wandisco.com>.
On 17.11.2013 21:08, Gabriela Gibson wrote:
> Thank you Ivan,
>
> I was blithely assuming that because I was removing trivial changes I
> introduced to the branch, that no-one would track them :) Also I was
> trying to avoid writing trivial things for people to read.
>
> The log message is fixed now.
>
> Now I'm curious -- what tools do people use to revise patches that allow
> them to instantly spot (seemingly) minor additions?
Do you mean "revise patches" or "review commits"? If it's the latter,
the fact that the list of affected files in the log message and the
automatically generated list of changes in the commit mail are different
is an obvious hint that something was either left out of the log
message, or inadvertently committed.
-- Brane
--
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com
Re: svn commit: r1542741 [1/3] - in /subversion/branches/invoke-diff-cmd-feature:
BRANCH-README subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Posted by Gabriela Gibson <ga...@gmail.com>.
Thank you Ivan,
I was blithely assuming that because I was removing trivial changes I
introduced to the branch, that no-one would track them :) Also I was
trying to avoid writing trivial things for people to read.
The log message is fixed now.
Now I'm curious -- what tools do people use to revise patches that allow
them to instantly spot (seemingly) minor additions?
Many thanks,
Gabriela
On Sun, Nov 17, 2013 at 3:02 PM, Ivan Zhakov <iv...@visualsvn.com> wrote:
> On 17 November 2013 18:56, <gb...@apache.org> wrote:
> > Author: gbg
> > Date: Sun Nov 17 14:56:28 2013
> > New Revision: 1542741
> >
> > URL: http://svn.apache.org/r1542741
> > Log:
> > On the invoke-diff-cmd-feature branch: Update BRANCH-README file.
> > Trivial white space changes to assorted files.
> >
> > * BRANCH-README: Update general shape and rework all log messages.
> > Add new diff file.
> >
> > Modified:
> > subversion/branches/invoke-diff-cmd-feature/BRANCH-README
> >
> subversion/branches/invoke-diff-cmd-feature/subversion/include/svn_io.h
> >
> subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_client/diff.c
> > subversion/branches/invoke-diff-cmd-feature/subversion/svn/svn.c
> >
> subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c
> >
> Dear Gabriel,
>
> Your log message doesn't match real changes again. Many people
> reviewing all commits and such commits are distracting.
>
>
> --
> Ivan Zhakov
>
Re: svn commit: r1542741 [1/3] - in /subversion/branches/invoke-diff-cmd-feature:
BRANCH-README subversion/include/svn_io.h subversion/libsvn_client/diff.c
subversion/svn/svn.c subversion/svnlook/svnlook.c
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 17 November 2013 18:56, <gb...@apache.org> wrote:
> Author: gbg
> Date: Sun Nov 17 14:56:28 2013
> New Revision: 1542741
>
> URL: http://svn.apache.org/r1542741
> Log:
> On the invoke-diff-cmd-feature branch: Update BRANCH-README file.
> Trivial white space changes to assorted files.
>
> * BRANCH-README: Update general shape and rework all log messages.
> Add new diff file.
>
> Modified:
> subversion/branches/invoke-diff-cmd-feature/BRANCH-README
> subversion/branches/invoke-diff-cmd-feature/subversion/include/svn_io.h
> subversion/branches/invoke-diff-cmd-feature/subversion/libsvn_client/diff.c
> subversion/branches/invoke-diff-cmd-feature/subversion/svn/svn.c
> subversion/branches/invoke-diff-cmd-feature/subversion/svnlook/svnlook.c
>
Dear Gabriel,
Your log message doesn't match real changes again. Many people
reviewing all commits and such commits are distracting.
--
Ivan Zhakov