You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2010/01/03 09:40:54 UTC
[jira] Created: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
The add address feature in order manager/order creation is broken
-----------------------------------------------------------------
Key: OFBIZ-3390
URL: https://issues.apache.org/jira/browse/OFBIZ-3390
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Jacques Le Roux
Fix For: SVN trunk
When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-3390) The add address feature
in order manager/order creation is broken
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805412#action_12805412 ]
Jacques Le Roux edited comment on OFBIZ-3390 at 1/27/10 8:24 AM:
-----------------------------------------------------------------
Hi Hans,
I can reproduce it in less than 30 seconds (it's more to explain ;)). Steps on demo server:
# From ordermanager create an order with admin as client (simply because admin has no postal address, any other with no postal address will get the same result)
# Order a product (say GZ-1000)
# Quick Finalize the order
# As admin has no address you need to create one (Add Address in quick finalize screen)
# You get the error :
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://party/widget/partymgr/PartyScreens.xml#editcontactmech]: java.lang.IllegalArgumentException: Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml] (Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml])
As I alreadys said, it works in 9.04, but there you can't get back to the quick finalize screen
*********EDIT TYPO*********
HTH
was (Author: jacques.le.roux):
Hi Hans,
I can reproduce it in less than 30 seconds (it's more to explain ;)). Steps on demo server:
# From ordermanager create an order with admin as client (simply because admin has no postal address, any other with no postal address will get the same result)
# Order a product (say GZ-1000)
# Quick Finalize the order
# As admin has no address you need to create one (Add Address in quick finalize screen)
# You get the error :
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://party/widget/partymgr/PartyScreens.xml#editcontactmech]: java.lang.IllegalArgumentException: Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml] (Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml])
As I alreadys said, it works in 9.04, but thereiyou can't get back to the quick finalize screen
HTH
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Hans Bakker
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805412#action_12805412 ]
Jacques Le Roux commented on OFBIZ-3390:
----------------------------------------
Hi Hans,
I can reproduce it in less than 30 seconds (it's more to explain ;)). Steps on demo server:
# From ordermanager create an order with admin as client (simply because admin has no postal address, any other with no postal address will get the same result)
# Order a product (say GZ-1000)
# Quick Finalize the order
# As admin has no address you need to create one (Add Address in quick finalize screen)
# You get the error :
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://party/widget/partymgr/PartyScreens.xml#editcontactmech]: java.lang.IllegalArgumentException: Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml] (Could not find screen with name [CommonPartyDecorator] in class resource [component://order/widget/ordermgr/CommonScreens.xml])
As I alreadys said, it works in 9.04, but thereiyou can't get back to the quick finalize screen
HTH
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Hans Bakker
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801021#action_12801021 ]
Scott Gray commented on OFBIZ-3390:
-----------------------------------
Steps to reproduce please
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801842#action_12801842 ]
Scott Gray commented on OFBIZ-3390:
-----------------------------------
Looks like Hans changed the decorator name of CommonPartyScreens.xml#editcontactmech from "main-decorator" to "CommonPartyDecorator" in r834010 which broke this view because the ordermgr/CommonScreens.xml does not have a CommonPartyDecorator. Solution would be to either switch it back to main-decorator or to add the CommonPartyDecorator to ordermgr/CommonScreens.xml
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Gray reassigned OFBIZ-3390:
---------------------------------
Assignee: Hans Bakker
Assigning to Hans to see if he has input to provide. Hans, if not then just assign it back to me and I'll take care of it (one way or another).
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Hans Bakker
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-3390) The add address feature in order manager/order creation is broken
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
Fellow committer - this is setting the bar too low IMO - we all make errors, but just assuming they'll happen and leaving the rest of the community to clean it up - that's another story.
And this number is not a particularly relevant number standing all alone by itself. Having to make so many commits because you make so many errors doesn't make it necessarily better for the community. The guy who gets lots of rebounds in basketball shouldn't spend most of his time getting his own rebounds on his own misses is all that I'm saying :)
Hopefully you can laugh with me a bit - said tongue in cheek, smiling, and meant to lighten the mood around here a bit. Let's just say it was a set up - an alley-oop shall we say - that I just couldn't leave sitting there!
All joking aside, two things stick out to me:
1. As a committer you do provide a ton of new functionality - thanks for that
2. I have not seen anything in our fellow committer's notes on the subject to imply that they are trying to prove that you make errors - only pointing out the ones that are there and what impact they are having on the system.
So, let's try and back off of them, they're like the most even-keeled person in the project and are really trying to help you and the project out by helping to make things more consistent.
Cheers,
Committer
PS - I don't think anyone's out to get you - only trying to improve the code base and predictability of this system we are all basing our careers around ....
On Jan 27, 2010, at 12:15 AM, Committer (JIRA) wrote:
> By the way if you want to prove that i make errors, i can confirm that that i do that.....with lots of commits, lots of errors (last year almost 1000 commits)
Re: [jira] Commented: (OFBIZ-3390) The add address feature in order manager/order creation is broken
Posted by Scott Gray <sc...@hotwaxmedia.com>.
On 27/01/2010, at 12:15 AM, Hans Bakker (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805394#action_12805394 ]
>
> Hans Bakker commented on OFBIZ-3390:
> ------------------------------------
>
> i tried it on the trunk and i do not have the error. Scott if you can reproduce it and want to fix it use the "ommonPartyDecorator to ordermgr/CommonScreens.xml" solution other wise other components will not work anymore.....
>
> By the way if you want to prove that i make errors, i can confirm that that i do that.....with lots of commits, lots of errors (last year almost 1000 commits)
Thanks for confirming Hans, I'm sorry that you make lots of errors and then get mad at me for dealing with them. In the future I'll do my best to get your input without pointing out that you caused the problem.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805394#action_12805394 ]
Hans Bakker commented on OFBIZ-3390:
------------------------------------
i tried it on the trunk and i do not have the error. Scott if you can reproduce it and want to fix it use the "ommonPartyDecorator to ordermgr/CommonScreens.xml" solution other wise other components will not work anymore.....
By the way if you want to prove that i make errors, i can confirm that that i do that.....with lots of commits, lots of errors (last year almost 1000 commits)
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Hans Bakker
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838286#action_12838286 ]
Jacques Le Roux commented on OFBIZ-3390:
----------------------------------------
Great, thanks Erwan!
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES reassigned OFBIZ-3390:
-----------------------------------------
Assignee: Erwan de FERRIERES (was: Hans Bakker)
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erwan de FERRIERES closed OFBIZ-3390.
-------------------------------------
Resolution: Fixed
Done at r916205
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Erwan de FERRIERES
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3390) The add address feature in order
manager/order creation is broken
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801164#action_12801164 ]
Jacques Le Roux commented on OFBIZ-3390:
----------------------------------------
Hi Scott,
When you create a sale order from the order manager with admin as customer (actually any customer without a postal address) and use Quick Finalise. Then you must create an address. In trunk you get an error. The problem is it's calling a CommonPartyDecorator that does not exist in ordermgr. I quickly/dirty tried to add it but then when you want to get back it does not work (missing an home for backHome request). In 9.04 you get to change the address but can't get back as well. Sorry I have no time to investigate further
Thanks
> The add address feature in order manager/order creation is broken
> -----------------------------------------------------------------
>
> Key: OFBIZ-3390
> URL: https://issues.apache.org/jira/browse/OFBIZ-3390
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Fix For: SVN trunk
>
>
> When you create an order with the order manager and need to add an address you get an error message. I did test only with trunk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.