You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2025/12/28 15:25:31 UTC
svn commit: r1930926 - pdfbox/branches/3.0/xmpbox/src/main/java/org/apache/xmpbox/type
Author: tilman
Date: Sun Dec 28 15:25:31 2025
New Revision: 1930926
Log:
PDFBOX-6133: refactor
Modified:
pdfbox/branches/3.0/xmpbox/src/main/java/org/apache/xmpbox/type/TypeMapping.java
Modified: pdfbox/branches/3.0/xmpbox/src/main/java/org/apache/xmpbox/type/TypeMapping.java
==============================================================================
--- pdfbox/branches/3.0/xmpbox/src/main/java/org/apache/xmpbox/type/TypeMapping.java Sun Dec 28 15:25:27 2025 (r1930925)
+++ pdfbox/branches/3.0/xmpbox/src/main/java/org/apache/xmpbox/type/TypeMapping.java Sun Dec 28 15:25:31 2025 (r1930926)
@@ -353,6 +353,9 @@ public final class TypeMapping
*/
public PropertyType getSpecifiedPropertyType(QName qName, String parentTypeName) throws BadFieldValueException
{
+ // PDFBOX-6133: the method was rewritten because of photoshop and exif,
+ // because these namespaces exist as a schema and as a type
+ // "factory" is checked in the non-schema part to keep the pre PDFBOX-6133 behavior
XMPSchemaFactory factory = getSchemaFactory(qName.getNamespaceURI());
if (factory != null)
{
@@ -365,12 +368,11 @@ public final class TypeMapping
}
// try in structured
List<Types> list = structuredNamespaces2.get(qName.getNamespaceURI());
- Types st;
if (list != null)
{
- st = list.get(0);
if (list.size() == 1)
{
+ Types st = list.get(0);
PropertiesDescription propDesc = structuredMappings.get(st);
if (factory == null || propDesc.getPropertiesNames().contains(qName.getLocalPart()))
{
@@ -392,20 +394,10 @@ public final class TypeMapping
PropertiesDescription propDesc = structuredMappings.get(type);
if (propDesc.getPropertiesNames().contains(qName.getLocalPart()))
{
- st = type;
- break;
+ return createPropertyType(type, Cardinality.Simple);
}
}
}
-
- PropertyType propertyType = createPropertyType(st, Cardinality.Simple);
- PropertiesDescription propertiesDescription = getStructuredPropMapping(propertyType.type());
- // PDFBOX-6133: do an additional check to make sure that the name exists.
- // This can happen with photoshop and exif because the namespace exists as a schema and as a type
- if (propertiesDescription.getPropertiesNames().contains(qName.getLocalPart()))
- {
- return propertyType;
- }
return null;
}
else