[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #14292: Do not emit negative lag because of stale offsets

["abhishekagarwal87 (via GitHub)" <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #14292:
URL: https://github.com/apache/druid/pull/14292#discussion_r1195297585


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4220,6 +4220,16 @@ protected void emitLag()
           return;
         }
 
+        // Try emitting lag even with stale metrics provided that none of the partitions has negative lag
+        final boolean areOffsetsStale = sequenceLastUpdated != null
+                                        && sequenceLastUpdated.isBefore(
+            System.currentTimeMillis() - tuningConfig.getOffsetFetchPeriod().getMillis()
+        );
+        if (areOffsetsStale && partitionLags.values().stream().anyMatch(x -> x < 0)) {
+          log.warn("Skipping negative lag emission as fetched offsets are stale");

Review Comment:
   lets rephrase it in a way that is more informative for someone reading this. 
   Lag is negative and will not be emitted because topic offsets have become stale. This will not impact data processing. Offsets become stale because.... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org