[jira] [Commented] (MAPREDUCE-5827) TestSpeculativeExecutionWithMRApp fails

["Zhijie Shen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966067#comment-13966067 ] 

Zhijie Shen commented on MAPREDUCE-5827:
----------------------------------------

The test cases have two race conditions:

1. maxTimeWait = 10 is sometimes not enough to wait for the results we want. Actually we can remove, and make the loop run until we get the result we want, because the test case has timeout set.

2. No need to check the speculative attempt, as when the MR job gets finished, it may still not reach the final state.
{code}
app.waitForState(ta[1], TaskAttemptState.KILLED);
    boolean foundSpecMsg = false;
    for (String msg : ta[1].getDiagnostics()) {
      if (msg.contains("Speculation")) {
        foundSpecMsg = true;
        break;
      }
    }
    Assert.assertTrue("No speculation diagnostics!", foundSpecMsg);
{code}

> TestSpeculativeExecutionWithMRApp fails
> ---------------------------------------
>
>                 Key: MAPREDUCE-5827
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5827
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>              Labels: test
>         Attachments: MAPREDUCE-5827.1.patch
>
>
> {code}
> junit.framework.AssertionFailedError: Couldn't speculate successfully
> 	at junit.framework.Assert.fail(Assert.java:50)
> 	at junit.framework.Assert.assertTrue(Assert.java:20)
> 	at org.apache.hadoop.mapreduce.v2.TestSpeculativeExecutionWithMRApp.testSpeculateSuccessfulWithoutUpdateEvents(TestSpeculativeExecutionWithMRApp.java:122
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)