You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/21 12:20:55 UTC

[GitHub] [incubator-devlake] klesh opened a new issue, #2572: [Bug][config-ui] Blueprint step 2 validation works partially

klesh opened a new issue, #2572:
URL: https://github.com/apache/incubator-devlake/issues/2572

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What happened
   
   When Jira is invalid, the Next Step gets disabled, which is correct
   ![image](https://user-images.githubusercontent.com/61080/180211645-f220c776-c10c-4972-aaea-d52d560ae804.png)
   However, if I switch to Github while Jira is still invalid, it gets enabled, and I can proceed to the Next Step
   ![image](https://user-images.githubusercontent.com/61080/180211929-5354c309-f388-46fd-9be0-cffd0614957a.png)
   
   
   
   
   ### What you expected to happen
   
   the "Next Step" button should be disabled if any Invalid Connection in play.
   
   ### How to reproduce
   
   1. create new blueprint
   2. add multiple connections
   3. invalidate one connection, and switch to any valid connection
   4. see error
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   main
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] e2corporation commented on issue #2572: [Bug][config-ui] Blueprint step 2 validation works partially

Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #2572:
URL: https://github.com/apache/incubator-devlake/issues/2572#issuecomment-1191472610

   @klesh  I left this behavior intentionally. I could scan all connections I think that's a bit overkill, I think this is acceptable for now given the current behavior is only worse in that we have no validation in place. We could patch this under another PR or if its a blocker we can address it on this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] klesh closed issue #2572: [Bug][config-ui] Blueprint step 2 validation works partially

Posted by GitBox <gi...@apache.org>.
klesh closed issue #2572: [Bug][config-ui] Blueprint step 2 validation works partially
URL: https://github.com/apache/incubator-devlake/issues/2572


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org