You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/02 08:39:05 UTC
[GitHub] [flink] wangyang0918 commented on a change in pull request #11245:
[FLINK-15794][Kubernetes] Generate the Kubernetes default image version
wangyang0918 commented on a change in pull request #11245: [FLINK-15794][Kubernetes] Generate the Kubernetes default image version
URL: https://github.com/apache/flink/pull/11245#discussion_r386253579
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -121,8 +122,11 @@
public static final ConfigOption<String> CONTAINER_IMAGE =
key("kubernetes.container.image")
.stringType()
- .defaultValue("flink:latest")
- .withDescription("Image to use for Flink containers.");
+ .defaultValue("flink:" + Version.PROJECT_VERSION + "-scala_" + Version.SCALA_VERSION)
Review comment:
Could we simply use `EnvironmentInformation#getVersion()` to get the project version? And i think we do not need the scalar version. Since we always have a image tag corresponding to the Flink version(with scala 2.12 built in).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services