You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2026/02/24 15:13:24 UTC
[PR] Add delay in `example_emr_eks` after updating execution role [airflow]
vincbeck opened a new pull request, #62415:
URL: https://github.com/apache/airflow/pull/62415
`example_emr_eks` is failing times to times because the EMR job does not have any credentials. It *seems* this could be a race condition, after updating the trust policy execution role, it does not have time to propagate before the job starts. Adding a sleep to see if it fixes anything.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add delay in `example_emr_eks` after updating execution role [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #62415:
URL: https://github.com/apache/airflow/pull/62415#discussion_r2848877181
##########
providers/amazon/tests/system/amazon/aws/example_emr_eks.py:
##########
@@ -173,6 +174,9 @@ def update_trust_policy_execution_role(cluster_name, cluster_namespace, role_nam
if build.returncode != 0:
raise RuntimeError(err)
+ # Wait for IAM changes to propagate to avoid authentication failures
+ time.sleep(10)
Review Comment:
Since this issue is very transient, it is very hard to test it. I like your idea, we can do that, I'll update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add delay in `example_emr_eks` after updating execution role [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #62415:
URL: https://github.com/apache/airflow/pull/62415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add delay in `example_emr_eks` after updating execution role [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #62415:
URL: https://github.com/apache/airflow/pull/62415#discussion_r2848841117
##########
providers/amazon/tests/system/amazon/aws/example_emr_eks.py:
##########
@@ -173,6 +174,9 @@ def update_trust_policy_execution_role(cluster_name, cluster_namespace, role_nam
if build.returncode != 0:
raise RuntimeError(err)
+ # Wait for IAM changes to propagate to avoid authentication failures
+ time.sleep(10)
Review Comment:
Were you able to test if 10s is enough? We could optionally make this a variable through the context builder so that we can change the time easily without needing to PR each time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org