You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/20 15:23:26 UTC
[GitHub] [kafka] iprithv opened a new pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
iprithv opened a new pull request #9204:
URL: https://github.com/apache/kafka/pull/9204
adding missing fields for --deep-iteration log messages.
Missing fields include : partitionLeaderEpoch, baseSequence, lastSequence, etc.,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731525092
@iprithv Thanks for you patch. I have assigned https://issues.apache.org/jira/browse/KAFKA-6181 to you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520431846
##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -257,8 +257,12 @@ object DumpLogSegments {
}
lastOffset = record.offset
- print(s"$RecordIndent offset: ${record.offset} ${batch.timestampType}: ${record.timestamp} " +
- s"keysize: ${record.keySize} valuesize: ${record.valueSize}")
+ print(s"$RecordIndent offset: ${record.offset} isValid: ${record.isValid} crc: ${record.checksumOrNull} "+
+ s" keySize: ${record.keySize} valueSize: ${record.valueSize} ${batch.timestampType}: ${record.timestamp} "+
+ s" baseOffset: ${batch.baseOffset} lastOffset: ${batch.lastOffset} baseSequence: ${batch.baseSequence} " +
+ s" lastSequence: ${batch.lastSequence} producerEpoch: ${batch.producerEpoch} partitionLeaderEpoch: ${batch.partitionLeaderEpoch} " +
+ s" size: ${batch.sizeInBytes} magic: ${batch.magic} compressType: ${batch.compressionType} position: ${validBytes} ")
Review comment:
```size``` is unclear to me. How about ```batchSize```?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520336051
##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -257,8 +257,11 @@ object DumpLogSegments {
}
lastOffset = record.offset
- print(s"$RecordIndent offset: ${record.offset} ${batch.timestampType}: ${record.timestamp} " +
- s"keysize: ${record.keySize} valuesize: ${record.valueSize}")
+ print(s"$RecordIndent offset: ${record.offset} baseOffset: ${batch.baseOffset} lastOffset: ${batch.lastOffset} baseSequence: ${} ${batch.baseSequence}" +
+ s" lastSequence: ${batch.lastSequence} producerEpoch: ${batch.producerEpoch} partitionLeaderEpoch: ${batch.partitionLeaderEpoch} position: ${validBytes} " +
+ s" ${batch.timestampType}: ${record.timestamp} isvalid: ${record.isValid}"+
+ s" keysize: ${record.keySize} valuesize: ${record.valueSize} size: ${batch.sizeInBytes} magic: ${batch.magic} " +
Review comment:
@chia7712 Have seperated the record details from batch details. Also changed the entries to camel case. Please review this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-678445541
Call for review @hachikuji @cmccabe (seem to be an easy one)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv edited a comment on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv edited a comment on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815
please review this @mjsax Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-723764315
Hi @chia7712 @hachikuji @cmccabe please review this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-726159989
@iprithv Thanks for the sharing. nit: there is a redundant space before “batchSize”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520297478
##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -257,8 +257,11 @@ object DumpLogSegments {
}
lastOffset = record.offset
- print(s"$RecordIndent offset: ${record.offset} ${batch.timestampType}: ${record.timestamp} " +
- s"keysize: ${record.keySize} valuesize: ${record.valueSize}")
+ print(s"$RecordIndent offset: ${record.offset} baseOffset: ${batch.baseOffset} lastOffset: ${batch.lastOffset} baseSequence: ${} ${batch.baseSequence}" +
+ s" lastSequence: ${batch.lastSequence} producerEpoch: ${batch.producerEpoch} partitionLeaderEpoch: ${batch.partitionLeaderEpoch} position: ${validBytes} " +
+ s" ${batch.timestampType}: ${record.timestamp} isvalid: ${record.isValid}"+
+ s" keysize: ${record.keySize} valuesize: ${record.valueSize} size: ${batch.sizeInBytes} magic: ${batch.magic} " +
Review comment:
isvalid -> "isValid"
keysize -> "keySize"
valuesize -> "valueSize"
compresscodec -> "compressionType"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 merged pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9204:
URL: https://github.com/apache/kafka/pull/9204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-730972056
@iprithv Could you share your jira account to me? I want to assign https://issues.apache.org/jira/browse/KAFKA-6181 to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-727772418
@chia7712 have removed the redundant space and have attached a screenshot. Please do review and merge the same.
<img width="1058" alt="nit" src="https://user-images.githubusercontent.com/48927540/99220741-368ba100-2805-11eb-905b-1bcfaedd13dd.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-677733815
please review this @mjsax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-726148418
Thanks for approving @chia7712 , have attached the images of before and after message.
<img width="1639" alt="After" src="https://user-images.githubusercontent.com/48927540/98959127-fb4d5180-2528-11eb-9f72-4bd8d612b906.png">
<img width="1499" alt="Before" src="https://user-images.githubusercontent.com/48927540/98959135-fdafab80-2528-11eb-9690-af40ab10820d.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731225730
Sincere apologies for the delay in response. My jira account is iprithv@gmail.com
Username: iprithv
Full name: Prithvi
Also I have commented in Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv commented on a change in pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#discussion_r520491160
##########
File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala
##########
@@ -257,8 +257,12 @@ object DumpLogSegments {
}
lastOffset = record.offset
- print(s"$RecordIndent offset: ${record.offset} ${batch.timestampType}: ${record.timestamp} " +
- s"keysize: ${record.keySize} valuesize: ${record.valueSize}")
+ print(s"$RecordIndent offset: ${record.offset} isValid: ${record.isValid} crc: ${record.checksumOrNull} "+
+ s" keySize: ${record.keySize} valueSize: ${record.valueSize} ${batch.timestampType}: ${record.timestamp} "+
+ s" baseOffset: ${batch.baseOffset} lastOffset: ${batch.lastOffset} baseSequence: ${batch.baseSequence} " +
+ s" lastSequence: ${batch.lastSequence} producerEpoch: ${batch.producerEpoch} partitionLeaderEpoch: ${batch.partitionLeaderEpoch} " +
+ s" size: ${batch.sizeInBytes} magic: ${batch.magic} compressType: ${batch.compressionType} position: ${validBytes} ")
Review comment:
Thanks @chia7712, makes sense. Have updated it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-730154806
rebase patch to trigger QA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-727809410
@iprithv Could you rebase code (or add trivial change) to trigger QA again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] iprithv edited a comment on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields
Posted by GitBox <gi...@apache.org>.
iprithv edited a comment on pull request #9204:
URL: https://github.com/apache/kafka/pull/9204#issuecomment-731225730
@chia7712 Sincere apologies for the delay in response. My jira account is iprithv@gmail.com
Username: iprithv
Full name: Prithvi
Also I have commented in Jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org