[jira] [Commented] (LIBCLOUD-593) CloudStack driver's create_node fails to join network_id when network_id is int

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052833#comment-14052833 ] 

ASF GitHub Bot commented on LIBCLOUD-593:
-----------------------------------------

GitHub user atsaki opened a pull request:

    https://github.com/apache/libcloud/pull/336

    [LIBCLOUD-593] CloudStack driver's create_node fails to join network_id ...

    CloudStack driver's create_node accept an argument "networks" it is used to specify networks the node will be connected to.
    networks is a list of CloudStackNetwork instances and their id is joined to construct a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network id is string but some implementation uses integer network id.
    When network id is integer, the code like following fails.
    networks = driver.ex_list_networks()
    node = driver.create_node(location, image, size, networks=networks)
    This patch convert network id into str explicitly before joining network ids.
    
    https://issues.apache.org/jira/browse/LIBCLOUD-593

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atsaki/libcloud 593-convert_network_id_to_str

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #336
    
----
commit a0ad7845a7cd5b380af5a707b69de1b042bedaf9
Author: Atsushi Sasaki <at...@gmail.com>
Date:   2014-07-05T10:55:22Z

    [LIBCLOUD-593] CloudStack driver's create_node fails to join network_id when network_id is int

----


> CloudStack driver's create_node fails to join network_id when network_id is int
> -------------------------------------------------------------------------------
>
>                 Key: LIBCLOUD-593
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-593
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.13.0, 0.13.1, 0.13.2, 0.14.0-beta3, 0.13.3
>            Reporter: Atsushi Sasaki
>
> CloudStack driver's create_node accept an argument "networks" it is used to specify networks the node will be connected to.
> networks is a list of CloudStackNetwork instances and their id is joined to construct a argument for CloudStack API's deployVirtualMachine in create_node. It is OK when network id is string but some implementation uses integer network id.
> When network id is integer, the code like following fails.
> networks = driver.ex_list_networks()
> node = driver.create_node(location, image, size, networks=networks)
> This patch convert network id into str explicitly before joining network ids.



--
This message was sent by Atlassian JIRA
(v6.2#6252)