You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/11/05 22:07:23 UTC

[GitHub] keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder

keith-turner edited a comment on issue #747: Shorten method names in AccumuloClient builder
URL: https://github.com/apache/accumulo/issues/747#issuecomment-436053391
 
 
   I am not a fan of all of the `with` prefix names. If all optional paths have it then I think it adds noise with no value.
   
   I have mixed feelings about `from(Path)` vs `from(String)` because I think 99% of code will be `from(Paths.get(filePath))`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services